Skip to content

Conversation

@jwaisner
Copy link
Contributor

@jwaisner jwaisner commented Apr 20, 2025

PR Type

enhancement, configuration changes


Description

  • Add Python 3.12.9 and 3.13.2 environment directories

    • Include configuration files for each version
    • Add Windows batch launchers for both versions
    • Provide wheel installation scripts and properties
  • Update bundle release version in build configuration


Changes walkthrough 📝

Relevant files
Enhancement
4 files
python.bat
Add Windows batch launcher for Python 3.12.9                         
+6/-0     
install.bat
Add wheel installation script for Python 3.12.9                   
+5/-0     
python.bat
Add Windows batch launcher for Python 3.13.2                         
+6/-0     
install.bat
Add wheel installation script for Python 3.13.2                   
+5/-0     
Configuration changes
5 files
bearsampp.conf
Add configuration file for Python 3.12.9                                 
+6/-0     
wheel.properties
Add wheel properties for Python 3.12.9                                     
+1/-0     
bearsampp.conf
Add configuration file for Python 3.13.2                                 
+6/-0     
wheel.properties
Add wheel properties for Python 3.13.2                                     
+1/-0     
build.properties
Update bundle release version to 2025.4.19                             
+1/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • @jwaisner jwaisner requested a review from N6REJ as a code owner April 20, 2025 03:02
    @jwaisner jwaisner added the enhancement ✨ Improve program label Apr 20, 2025
    @qodo-merge-pro
    Copy link

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Version Mismatch

    The install script references pywin32-310-cp312-cp312-win_amd64.whl which has "310" in the filename despite being for Python 3.12. Verify if this naming convention is correct or if it should be updated to match the Python version.

    "%WINPYDIR%\Scripts\pip.exe" install pywin32-310-cp312-cp312-win_amd64.whl
    
    Version Mismatch

    The install script references pywin32-310-cp313-cp313-win_amd64.whl which has "310" in the filename despite being for Python 3.13. Verify if this naming convention is correct or if it should be updated to match the Python version.

    "%WINPYDIR%\Scripts\pip.exe" install pywin32-310-cp313-cp313-win_amd64.whl
    

    @qodo-merge-pro
    Copy link

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    @N6REJ N6REJ merged commit abc46be into main Apr 23, 2025
    @N6REJ N6REJ deleted the 3.13.2-3.12.9 branch April 23, 2025 04:46
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    3 participants