Test with vitest and pngjs #21
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Uses https://www.npmjs.com/package/pngjs - Separates rendering of data url in DOM/browser (canvas) from rendering in node/testing (pngjs) - For testing, data URLs are different; using decoded pixel bytes
- Setting longer timeout, as tests make calls that can take a few secs - Updating package.json and tsconfig.json to account for the new parts
…nat/ome-zarr.js into test_with_vitest_and_pngjs
Collaborator
|
Tests are running 👍 |
This was referenced Nov 11, 2025
Closed
Note: running npm install with my npm version normalized package-lock.json and removed per-package license fields; happy to adjust if the project prefers a specific npm version / lockfile format.
Author
|
@lubianat tried fixing it here; workflow re-running needs approval |
Collaborator
|
Build is green and tests passed 👍 Thanks... brb.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building upon Will's
on a new PR
In relation to that, I've experimented on extracting out some parts of renderImage and on using https://www.npmjs.com/package/pngjs for testing without a browser
I've rolled back on JSdom for that, but we can go that path anyways
Will added "next step would be for you to
Fixes #18.