-
Notifications
You must be signed in to change notification settings - Fork 386
feat: Enhance vis.py show routine #1855
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
winksaville
commented
Jun 3, 2025
- Add parameters azimuth viewup and clipping_range to allow for improved control of the rendering.
- Always call ResetCamera early so the camera is in a known state before applying user defined parameters, some of which are relative.
- Add parameters azimuth viewup and clipping_range to allow for improved control of the rendering. - Always call ResetCamera early so the camera is in a known state before applying user defined parameters, some of which are relative.
|
I've added this per the suggestion from @adam-urbanczyk in "Enhance show in vis.py" discussion #1844. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
+ Coverage 95.66% 95.77% +0.10%
==========================================
Files 28 29 +1
Lines 7431 7856 +425
Branches 1122 1183 +61
==========================================
+ Hits 7109 7524 +415
+ Misses 193 192 -1
- Partials 129 140 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a11b8d2 to
58e52a1
Compare
|
Anyone have any thoughts on this PR? |
|
Pls give it some time. |
Reset camera orientation if no explicit position is provided.
|
I'm a neophyte at all this so I asked the bot1 and it says always calling ResetCamera like I did was wrong It's solution was: The if statement double negative is odd and there are likely other issues, but the final call to I'd suggest asking for help on a VTK community forum and since this is well beyond my area of expertise I'll let you all decide how or whether to take this PR. Wink |
|
OK, let's merge this PR. Thanks @winksaville ! |