Skip to content

Conversation

@TheLastProject
Copy link
Member

@TheLastProject TheLastProject commented Jun 15, 2024

Fixes #1929

  • Write code to try icon first, then fall back to front or back
  • Generate header colour correctly (right now it always is based on the icon or random)
  • Fix the notable slowdown when scrolling through the main activity

To decide: how should this interact with #1889?

@TheLastProject
Copy link
Member Author

The slowdown seems to be caused by BitmapFactory.decodeStream(in); in Utils.retrieveCardImage.

This is generally just bad code, it should try to load the image async. It's not really directly linked to this, but if we're going to silently start loading more stuff we should consider being a bit more careful.

Simplifies the logic for the icon -> front -> back fallback
This ensures scrolling stays smooth on slow devices
@TheLastProject
Copy link
Member Author

Closing in favour of #1934 and #1933

@TheLastProject TheLastProject deleted the feature/fallbackIconToFrontOrBack branch June 16, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Front of Card Image not the default

1 participant