Add “Copy value” overflow action to card view #2789
+47
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* New menu item 'Copy value' (overflow only) * Helper copies cardId to system clipboard * Strings added: copy_value, copied_to_clipboard, nothing_to_copy * No UI regression; tested on fossDebug
Member
|
From a quick check this probably works, but is there any reason you haven't added this to the dialog that appears when tapping the barcode as decided in #2400? |
Author
|
No, I havent checked that. If you want I can implement that too.
…On Thu, 23 Oct, 2025, 10:32 pm Sylvia van Os, ***@***.***> wrote:
*TheLastProject* left a comment (CatimaLoyalty/Android#2789)
<#2789 (comment)>
From a quick check this probably works, but is there any reason you
haven't added this to the dialog that appears when tapping the barcode as
decided in #2400 <#2400>?
—
Reply to this email directly, view it on GitHub
<#2789 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW32Q3TRKPSFFJRPFXIAKPL3ZEC35AVCNFSM6AAAAACJ5PVNESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZYGEZDINZQGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Member
|
I think it would be better to only implement that version (long-press + new button on the dialog on short press) to keep the menu simpler :) |
Author
|
Ok, I will try to implement the changes you suggested in the #2400
…On Fri, 24 Oct, 2025, 12:23 am Sylvia van Os, ***@***.***> wrote:
*TheLastProject* left a comment (CatimaLoyalty/Android#2789)
<#2789 (comment)>
I think it would be better to *only* implement that version (long-press +
new button on the dialog on short press) to keep the menu simpler :)
—
Reply to this email directly, view it on GitHub
<#2789 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AW32Q3XFMW7JUQP6GSR6JWL3ZEP3ZAVCNFSM6AAAAACJ5PVNESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZYGYZDMMRVGA>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Author
|
I have implemented the changes you suggested. Please check. |
Author
|
Is this fine?
On Fri, 24 Oct 2025 at 00:28, Aditya Varma ***@***.***>
wrote:
… Ok, I will try to implement the changes you suggested in the #2400
On Fri, 24 Oct, 2025, 12:23 am Sylvia van Os, ***@***.***>
wrote:
> *TheLastProject* left a comment (CatimaLoyalty/Android#2789)
> <#2789 (comment)>
>
> I think it would be better to *only* implement that version (long-press
> + new button on the dialog on short press) to keep the menu simpler :)
>
> —
> Reply to this email directly, view it on GitHub
> <#2789 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AW32Q3XFMW7JUQP6GSR6JWL3ZEP3ZAVCNFSM6AAAAACJ5PVNESVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTIMZYGYZDMMRVGA>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
| builder.setPositiveButton(R.string.ok, (dialogInterface, i) -> dialogInterface.dismiss()); | ||
| builder.setPositiveButton(R.string.copy_value, (dialog, which) -> { | ||
| ClipboardManager cm = (ClipboardManager) getSystemService(CLIPBOARD_SERVICE); | ||
| cm.setPrimaryClip(ClipData.newPlainText("QR value", loyaltyCard.cardId)); |
Member
There was a problem hiding this comment.
"QR value" should be translatable. I think it makes more sense to use the cardId translatable
| builder.setTitle(R.string.cardId); | ||
| builder.setView(cardIdView); | ||
| builder.setPositiveButton(R.string.ok, (dialogInterface, i) -> dialogInterface.dismiss()); | ||
| builder.setPositiveButton(R.string.copy_value, (dialog, which) -> { |
Member
There was a problem hiding this comment.
I'm not sure if this makes sense as the positive button, the default action probably shouldn't be to copy to clipboard.
Comment on lines
+927
to
+929
| return true; | ||
| } else if (id == R.id.action_copy_value) { | ||
| copyValueToClipboard(); // <— helper you added earlier |
Member
There was a problem hiding this comment.
As discussed: not in the 3 dots menu please.
| } | ||
|
|
||
| ClipboardManager cm = (ClipboardManager) getSystemService(CLIPBOARD_SERVICE); | ||
| ClipData clip = ClipData.newPlainText("Card value", value); |
Member
There was a problem hiding this comment.
Let's also use the cardId translatable here.
Member
There was a problem hiding this comment.
Not needed because we don't want this in the menu
Comment on lines
+30
to
+34
| <item | ||
| android:id="@+id/action_copy_value" | ||
| android:title="@string/copy_value" | ||
| app:showAsAction="ifRoom" /> | ||
|
|
Member
There was a problem hiding this comment.
Also should be removed because we don't want it in the menu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What’s new
cardIdto the system clipboard viaClipboardManager.copy_value,copied_to_clipboard,nothing_to_copy.UX
Build variants tested
fossDebugon API 34 emulatorsrc/main, so it ships withgplay*too.No database or schema changes; 100 % additive.