Skip to content

[25.06.02 / TASK-202] hotfix: 쿠키에 max-age 값 없어서 세션 쿠키로 인식되고, 브라우저 종료시 아에 쿠키 삭제되어버림 #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025
Merged

[25.06.02 / TASK-202] hotfix: 쿠키에 max-age 값 없어서 세션 쿠키로 인식되고, 브라우저 종료시 아에 쿠키 삭제되어버림 #32

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ecd15b0
hotfix: 쿠키에 max-age 값 없어서 세션 쿠키로 인식되고, 브라우저 종료시 아에 쿠키 삭제되어버림
Nuung Jun 2, 2025
dcfafce
modify: 상수 위치 변경 ㅎㅎ
Nuung Jun 2, 2025
9203a7f
Merge branch 'main' into hotfix/cookie-max-age
Nuung Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/controllers/user.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ export class UserController {
constructor(private userService: UserService) { }

private cookieOption(): CookieOptions {
// eslint-disable-next-line @typescript-eslint/naming-convention
const THREE_WEEKS_IN_MS = 21 * 24 * 60 * 60 * 1000;
const isProd = process.env.NODE_ENV === 'production';

const baseOptions: CookieOptions = {
Expand All @@ -22,6 +24,7 @@ export class UserController {
if (isProd) {
baseOptions.sameSite = 'lax';
baseOptions.domain = "velog-dashboard.kro.kr";
baseOptions.maxAge = THREE_WEEKS_IN_MS; // 3주
} else {
baseOptions.domain = 'localhost';
}
Expand Down
Loading