Glasgow | Sheetal kharab | Module Legacy Code | WEEK 1| Hashtag link doesn't work correctly #27
+45
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheetalkharab
added
the
Needs Review
mjpeet
reviewed
Oct 26, 2025
There was a problem hiding this comment.
well done:
- Both blooms now generate the correct hashtag URL: /hashtag/SwizBiz
- The frontend hashtag parsing matches the backend's hashtag storage logic
- All hashtag links will work correctly regardless of punctuation or position in the text
- Proper URL encoding prevents any special character issues
.
|
|
||
|
|
||
| def add_bloom(*, sender: User, content: str) -> Bloom: | ||
| if len(content) > 280: |
There was a problem hiding this comment.
well done limiting content length in front end as well
|
|
||
| function _formatHashtags(text) { | ||
| if (!text) return text; | ||
| // special character in hashtag convert into url friendly format |
| return text.replace( | ||
| /\B#[^#]+/g, | ||
| (match) => `<a href="/hashtag/${match.slice(1)}">${match}</a>` | ||
| /\B#(\w+)/g, |
There was a problem hiding this comment.
good catch:
- /\B#(\w+)/g - Only captures word characters (letters, digits, underscore)
- Uses capturing group to extract just the tag name
- encodeURIComponent(tag) - Properly encodes for URLs
mjpeet
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.