Glasgow | Sheetal kharab | Module Legacy Code | WEEK 1| Hashtag slowing down my browser #28
Conversation
sheetalkharab
added
the
Needs Review
There was a problem hiding this comment.
great work on fiing the issue! HOWEVER , you need to e careful NOT to introduce code changes that are not related to the bugfix (i've seen several code changes which are for a different issue, and alsoquite a few changes where the code was reformatted - adding spaces here and there - these are a big NO in a work environment)
when you create a PR, you have an overview of all the changes - if there are changes which are not relevant to the PR, you should not create a PR, you need to go back to oyur changes and revert those that should not be in the PR
|
|
||
| def add_bloom(*, sender: User, content: str) -> Bloom: | ||
| if len(content) > 280: | ||
| raise ValueError("Bloom content must not exceed 280 character limit.") |
| const originalText = submitButton.textContent; | ||
| const textarea = form.querySelector("textarea"); | ||
| const content = textarea.value.trim(); | ||
| const charMaxLength = 280; |
There was a problem hiding this comment.
these changes should not be in this PR!
| return text.replace( | ||
| /\B#[^#]+/g, | ||
| (match) => `<a href="/hashtag/${match.slice(1)}">${match}</a>` | ||
| /\B#(\w+)/g, |
There was a problem hiding this comment.
these changes should not be in this PR!
| destroy(); | ||
|
|
||
| apiService.getBloomsByHashtag(hashtag); | ||
| if (formattedHashtag !== state.currentHashtag) { |
There was a problem hiding this comment.
great work introducing a condition on when to check the api!
mjpeet
added
Complete
2 participants
Learners, PR Template
Self checklist
Changelist
Briefly explain your PR.
Questions
Ask any questions you have for your reviewer.