London | 25-SDC-July | Andrei Filippov | Sprint 1 | Bug Report: Hashtag slowing down my browser #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Droid-An
added
the
Needs Review
mjpeet
reviewed
Oct 26, 2025
Comment on lines
+20
to
+24
| // Check that hashtag starts with hash to make right comparison with state | ||
| const hashtagWithHash = hashtag.startsWith("#") ? hashtag : `#${hashtag}`; | ||
| if (state.currentHashtag !== hashtagWithHash) { | ||
| apiService.getBloomsByHashtag(hashtag); | ||
| } |
There was a problem hiding this comment.
You've correctly identified the root cause - the function was calling the API every time without checking if it already had the data. Your solution to check state.currentHashtag !== hashtagWithHash before making the API call is exactly right! This prevents the infinite loop that was causing the browser to flash.
Nice attention to detail on the edge case check! You noticed that hashtags might come in with or without the # prefix, and you normalized it to ensure the comparison works correctly. This shows you're thinking about real-world usage scenarios.
Comment on lines
+1
to
+23
| import { test, expect } from "@playwright/test"; | ||
|
|
||
| test("should not make infinite hashtag endpoint requests", async ({ page }) => { | ||
| // ===== ARRANGE | ||
| const requests = []; | ||
| page.on("request", (request) => { | ||
| if ( | ||
| request.url().includes(":3000/hashtag/do") && | ||
| request.resourceType() === "fetch" | ||
| ) { | ||
| requests.push(request); | ||
| } | ||
| }); | ||
| // ====== ACT | ||
| // When I navigate to the hashtag | ||
| await page.goto("/#/hashtag/do"); | ||
| // And I wait a reasonable time for any additional requests | ||
| await page.waitForTimeout(200); | ||
|
|
||
| // ====== ASSERT | ||
| // Then the number of requests should be 1 | ||
| expect(requests.length).toEqual(1); | ||
| }); |
There was a problem hiding this comment.
Excellent addition of a regression test!
mjpeet
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
Changelist
Fixed issue with the hashtag view. To do this I needed to understand the application flow and make some tests to verify the fix.
Questions
Should playwright tests start in a new window called "Chromium"?