App v2 update #1373
Draft
App v2 update #1373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alpe
reviewed
May 3, 2023
Contributor
alpe
left a comment
alpe
left a comment
There was a problem hiding this comment.
Good start, let's add the module to app_v2_config.go and remove setup and legacy registration from app_v2.go
x/wasm/module.go
Outdated
| depinject.Out | ||
|
|
||
| Module appmodule.AppModule | ||
| WasmKeeper *Keeper |
Contributor
There was a problem hiding this comment.
It would be nice, if we can setup and return the scopedWasmKeeper as well.
x/wasm/module.go
Outdated
| WasmKeeper *Keeper | ||
| } | ||
|
|
||
| func provideModule(in wasmInputs) wasmOutputs { |
Contributor
There was a problem hiding this comment.
this function needs to be public or will cause an error on DI
Suggested change
| func provideModule(in wasmInputs) wasmOutputs { | |
| func ProvideModule(in wasmInputs) wasmOutputs { |
alpe
reviewed
May 3, 2023
x/wasm/module.go
Outdated
| depinject.Out | ||
|
|
||
| Module appmodule.AppModule | ||
| WasmKeeper *Keeper |
Contributor
There was a problem hiding this comment.
app_v2.go expects as value of the wasm Keeper. Either change it there or here
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import ( | ||
| fmt "fmt" | ||
| io "io" | ||
| reflect "reflect" |
Check notice
Code scanning / CodeQL
Sensitive package import
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1286
Blocked on ibc-go