Skip to content

Cache the results of getAssetFiles #3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −2
Draft

Cache the results of getAssetFiles #3181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c4669e9
Cache the results of getAssetFiles
cubercsl Nov 5, 2025
89d1433
Merge branch 'main' into patch-3
cubercsl Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions webapp/src/Service/DOMJudgeService.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,16 +1342,24 @@ public function apiRelativeUrl(string $route, array $params = []): string
return substr($route, strlen($apiRootRoute) + $offset);
}


/** @var array<string, string[]> */
private static array $assetFiles = [];

/**
* Get asset files in the given directory with the given extension
*
* @return string[]
*/
public function getAssetFiles(string $path): array
{
if (isset(self::$assetFiles[$path])) {
return self::$assetFiles[$path];
}

$customDir = sprintf('%s/public/%s', $this->params->get('kernel.project_dir'), $path);
if (!is_dir($customDir)) {
return [];
return self::$assetFiles[$path] = [];
}

$results = [];
Expand All @@ -1363,7 +1371,7 @@ public function getAssetFiles(string $path): array
}
}

return $results;
return self::$assetFiles[$path] = $results;
}

/**
Expand Down
Loading