Get Linux cross-compiling and tests working #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Linux toolchains (except x86-64 where I previously commented it out), there were hard-coded sysroot flags referring to the paths of Chromium's bundled dependencies. Get rid of this. On my machine the cross toolchains work fine without it. But I added a a 'sysroot' command line argument, so if anyone needs it they can pass sysroot=... on the scons command line to configure a --sysroot flag.
This one only seems to be triggered when a test fails.
Use system qemu-armhf for the emulator for tests. The command here basically matches what the run_under_qemu_arm script (which can be seen at tools/trusted_cross_toolchains/qemu_tool_arm.sh) was doing. Also change the emulator in run.py.
This fixes a NaCl syscall that only exists for a test. Fixes the run_infoleak_test test target on ARM.
REGS_SAVER_FUNC is meant to work even if the stack pointer is misaligned, but the multi-register PUSH instructions crash if the stack is misaligned, as per the ARM documentation. I guess the old(?) bundled QEMU used by upstream doesn't implement this faithfully. Fix it by using a series of single-register pushes instead. Fixes the run_register_set_test test target on ARM.
slipher
force-pushed
the
slipher/cross
branch
from
cd17f36 to
2621bc1
Compare
|
Added another bit to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get Linux cross-compile builds working to the x86 and armhf architectures. For x86 all the tests pass. For ARM I have the
small_testspassing so far. The command for running the ARM tests (requires the QEMU user-mode emulator to be installed when cross compiling) isscons --mode=opt-linux,nacl saigo=1 platform=arm small_tests.