-
Notifications
You must be signed in to change notification settings - Fork 314
Bump spotbugs gradle plugin to 6.4.2 #9748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bdu/test-decoupling-on-jdk21
Are you sure you want to change the base?
Bump spotbugs gradle plugin to 6.4.2 #9748
Conversation
…internal-api Also this forces JDK 11 to be the minimum.
# Conflicts: # communication/src/main/java/datadog/communication/ddagent/SharedCommunicationObjects.java # utils/test-utils/src/main/groovy/datadog/trace/test/util/DDSpecification.groovy
Debugger benchmarksParameters
See matching parameters
SummaryFound 3 performance improvements and 0 performance regressions! Performance is the same for 6 metrics, 6 unstable metrics.
See unchanged results
Request duration reports for reportsgantt
title reports - request duration [CI 0.99] : candidate=None, baseline=None
dateFormat X
axisFormat %s
section baseline
noprobe (322.865 µs) : 284, 362
. : milestone, 323,
basic (292.34 µs) : 286, 299
. : milestone, 292,
loop (8.956 ms) : 8953, 8959
. : milestone, 8956,
section candidate
noprobe (331.706 µs) : 280, 383
. : milestone, 332,
basic (279.828 µs) : 273, 286
. : milestone, 280,
loop (8.956 ms) : 8950, 8962
. : milestone, 8956,
|
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 60 metrics, 5 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~9510177cb5, baseline=1.55.0-SNAPSHOT~cd02b0c326
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1020146
Total [baseline] (8.656 s) : 0, 8656031
Agent [candidate] (1.018 s) : 0, 1017694
Total [candidate] (8.662 s) : 0, 8662452
section iast
Agent [baseline] (1.153 s) : 0, 1153314
Total [baseline] (9.3 s) : 0, 9300093
Agent [candidate] (1.152 s) : 0, 1151730
Total [candidate] (9.244 s) : 0, 9244137
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~9510177cb5, baseline=1.55.0-SNAPSHOT~cd02b0c326
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.453 ms) : 0, 1453
crashtracking [candidate] (1.443 ms) : 0, 1443
BytebuddyAgent [baseline] (695.422 ms) : 0, 695422
BytebuddyAgent [candidate] (693.511 ms) : 0, 693511
GlobalTracer [baseline] (243.2 ms) : 0, 243200
GlobalTracer [candidate] (242.11 ms) : 0, 242110
AppSec [baseline] (32.297 ms) : 0, 32297
AppSec [candidate] (32.227 ms) : 0, 32227
Debugger [baseline] (6.282 ms) : 0, 6282
Debugger [candidate] (6.419 ms) : 0, 6419
Remote Config [baseline] (681.456 µs) : 0, 681
Remote Config [candidate] (695.844 µs) : 0, 696
Telemetry [baseline] (9.35 ms) : 0, 9350
Telemetry [candidate] (9.24 ms) : 0, 9240
Flare Poller [baseline] (10.351 ms) : 0, 10351
Flare Poller [candidate] (10.949 ms) : 0, 10949
section iast
crashtracking [baseline] (1.494 ms) : 0, 1494
crashtracking [candidate] (1.471 ms) : 0, 1471
BytebuddyAgent [baseline] (816.503 ms) : 0, 816503
BytebuddyAgent [candidate] (816.451 ms) : 0, 816451
GlobalTracer [baseline] (232.151 ms) : 0, 232151
GlobalTracer [candidate] (231.165 ms) : 0, 231165
IAST [baseline] (26.918 ms) : 0, 26918
IAST [candidate] (26.443 ms) : 0, 26443
AppSec [baseline] (35.195 ms) : 0, 35195
AppSec [candidate] (35.222 ms) : 0, 35222
Debugger [baseline] (6.131 ms) : 0, 6131
Debugger [candidate] (6.118 ms) : 0, 6118
Remote Config [baseline] (599.383 µs) : 0, 599
Remote Config [candidate] (603.252 µs) : 0, 603
Telemetry [baseline] (8.762 ms) : 0, 8762
Telemetry [candidate] (8.588 ms) : 0, 8588
Flare Poller [baseline] (4.212 ms) : 0, 4212
Flare Poller [candidate] (4.173 ms) : 0, 4173
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~9510177cb5, baseline=1.55.0-SNAPSHOT~cd02b0c326
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025898
Total [baseline] (10.731 s) : 0, 10731185
Agent [candidate] (1.023 s) : 0, 1022987
Total [candidate] (10.67 s) : 0, 10669783
section appsec
Agent [baseline] (1.201 s) : 0, 1200534
Total [baseline] (10.864 s) : 0, 10864285
Agent [candidate] (1.192 s) : 0, 1191992
Total [candidate] (10.977 s) : 0, 10977282
section iast
Agent [baseline] (1.152 s) : 0, 1152080
Total [baseline] (11.064 s) : 0, 11063834
Agent [candidate] (1.149 s) : 0, 1149235
Total [candidate] (11.033 s) : 0, 11033302
section profiling
Agent [baseline] (1.164 s) : 0, 1163971
Total [baseline] (10.817 s) : 0, 10817443
Agent [candidate] (1.167 s) : 0, 1166938
Total [candidate] (11.054 s) : 0, 11054095
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~9510177cb5, baseline=1.55.0-SNAPSHOT~cd02b0c326
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.454 ms) : 0, 1454
BytebuddyAgent [baseline] (698.738 ms) : 0, 698738
BytebuddyAgent [candidate] (697.381 ms) : 0, 697381
GlobalTracer [baseline] (244.938 ms) : 0, 244938
GlobalTracer [candidate] (243.05 ms) : 0, 243050
AppSec [baseline] (32.73 ms) : 0, 32730
AppSec [candidate] (32.522 ms) : 0, 32522
Debugger [baseline] (6.385 ms) : 0, 6385
Debugger [candidate] (6.464 ms) : 0, 6464
Remote Config [baseline] (697.358 µs) : 0, 697
Remote Config [candidate] (692.299 µs) : 0, 692
Telemetry [baseline] (9.522 ms) : 0, 9522
Telemetry [candidate] (9.3 ms) : 0, 9300
Flare Poller [baseline] (10.261 ms) : 0, 10261
Flare Poller [candidate] (10.836 ms) : 0, 10836
section appsec
crashtracking [baseline] (1.484 ms) : 0, 1484
crashtracking [candidate] (1.44 ms) : 0, 1440
BytebuddyAgent [baseline] (721.947 ms) : 0, 721947
BytebuddyAgent [candidate] (716.396 ms) : 0, 716396
GlobalTracer [baseline] (236.137 ms) : 0, 236137
GlobalTracer [candidate] (233.839 ms) : 0, 233839
IAST [baseline] (25.112 ms) : 0, 25112
IAST [candidate] (24.745 ms) : 0, 24745
AppSec [baseline] (175.242 ms) : 0, 175242
AppSec [candidate] (175.402 ms) : 0, 175402
Debugger [baseline] (6.132 ms) : 0, 6132
Debugger [candidate] (6.071 ms) : 0, 6071
Remote Config [baseline] (637.87 µs) : 0, 638
Remote Config [candidate] (624.737 µs) : 0, 625
Telemetry [baseline] (8.616 ms) : 0, 8616
Telemetry [candidate] (8.438 ms) : 0, 8438
Flare Poller [baseline] (3.936 ms) : 0, 3936
Flare Poller [candidate] (3.932 ms) : 0, 3932
section iast
crashtracking [baseline] (1.448 ms) : 0, 1448
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (816.007 ms) : 0, 816007
BytebuddyAgent [candidate] (814.24 ms) : 0, 814240
GlobalTracer [baseline] (231.589 ms) : 0, 231589
GlobalTracer [candidate] (230.799 ms) : 0, 230799
IAST [baseline] (26.718 ms) : 0, 26718
IAST [candidate] (26.341 ms) : 0, 26341
AppSec [baseline] (35.184 ms) : 0, 35184
AppSec [candidate] (35.128 ms) : 0, 35128
Debugger [baseline] (6.158 ms) : 0, 6158
Debugger [candidate] (6.152 ms) : 0, 6152
Remote Config [baseline] (612.135 µs) : 0, 612
Remote Config [candidate] (610.221 µs) : 0, 610
Telemetry [baseline] (8.789 ms) : 0, 8789
Telemetry [candidate] (8.805 ms) : 0, 8805
Flare Poller [baseline] (4.202 ms) : 0, 4202
Flare Poller [candidate] (4.219 ms) : 0, 4219
section profiling
crashtracking [baseline] (1.468 ms) : 0, 1468
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (720.075 ms) : 0, 720075
BytebuddyAgent [candidate] (725.007 ms) : 0, 725007
GlobalTracer [baseline] (218.99 ms) : 0, 218990
GlobalTracer [candidate] (218.298 ms) : 0, 218298
AppSec [baseline] (32.377 ms) : 0, 32377
AppSec [candidate] (32.791 ms) : 0, 32791
Debugger [baseline] (6.61 ms) : 0, 6610
Debugger [candidate] (6.614 ms) : 0, 6614
Remote Config [baseline] (707.985 µs) : 0, 708
Remote Config [candidate] (781.966 µs) : 0, 782
Telemetry [baseline] (15.191 ms) : 0, 15191
Telemetry [candidate] (15.346 ms) : 0, 15346
Flare Poller [baseline] (4.872 ms) : 0, 4872
Flare Poller [candidate] (4.893 ms) : 0, 4893
ProfilingAgent [baseline] (109.879 ms) : 0, 109879
ProfilingAgent [candidate] (108.998 ms) : 0, 108998
Profiling [baseline] (110.549 ms) : 0, 110549
Profiling [candidate] (109.581 ms) : 0, 109581
LoadParameters
See matching parameters
SummaryFound 3 performance improvements and 1 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9510177cb5, baseline=1.55.0-SNAPSHOT~cd02b0c326
dateFormat X
axisFormat %s
section baseline
no_agent (4.415 ms) : 4365, 4464
. : milestone, 4415,
iast (9.657 ms) : 9496, 9817
. : milestone, 9657,
iast_FULL (13.967 ms) : 13691, 14243
. : milestone, 13967,
iast_GLOBAL (10.642 ms) : 10451, 10833
. : milestone, 10642,
profiling (8.83 ms) : 8694, 8965
. : milestone, 8830,
tracing (7.915 ms) : 7801, 8029
. : milestone, 7915,
section candidate
no_agent (4.262 ms) : 4211, 4313
. : milestone, 4262,
iast (9.313 ms) : 9155, 9471
. : milestone, 9313,
iast_FULL (14.48 ms) : 14194, 14766
. : milestone, 14480,
iast_GLOBAL (10.986 ms) : 10789, 11182
. : milestone, 10986,
profiling (9.003 ms) : 8862, 9144
. : milestone, 9003,
tracing (8.044 ms) : 7923, 8165
. : milestone, 8044,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9510177cb5, baseline=1.55.0-SNAPSHOT~cd02b0c326
dateFormat X
axisFormat %s
section baseline
no_agent (35.988 ms) : 35705, 36271
. : milestone, 35988,
appsec (47.803 ms) : 47373, 48233
. : milestone, 47803,
code_origins (45.228 ms) : 44837, 45618
. : milestone, 45228,
iast (45.343 ms) : 44939, 45747
. : milestone, 45343,
profiling (45.874 ms) : 45441, 46307
. : milestone, 45874,
tracing (45.02 ms) : 44635, 45404
. : milestone, 45020,
section candidate
no_agent (36.897 ms) : 36594, 37201
. : milestone, 36897,
appsec (48.577 ms) : 48142, 49012
. : milestone, 48577,
code_origins (43.424 ms) : 43052, 43796
. : milestone, 43424,
iast (43.311 ms) : 42952, 43670
. : milestone, 43311,
profiling (49.385 ms) : 48950, 49819
. : milestone, 49385,
tracing (45.482 ms) : 45076, 45888
. : milestone, 45482,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9510177cb5, baseline=1.55.0-SNAPSHOT~cd02b0c326
dateFormat X
axisFormat %s
section baseline
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.516 ms) : 2462, 2570
. : milestone, 2516,
iast (2.22 ms) : 2157, 2283
. : milestone, 2220,
iast_GLOBAL (2.266 ms) : 2201, 2330
. : milestone, 2266,
profiling (2.089 ms) : 2036, 2142
. : milestone, 2089,
tracing (2.039 ms) : 1990, 2089
. : milestone, 2039,
section candidate
no_agent (1.488 ms) : 1477, 1500
. : milestone, 1488,
appsec (3.673 ms) : 3458, 3887
. : milestone, 3673,
iast (2.218 ms) : 2154, 2282
. : milestone, 2218,
iast_GLOBAL (2.26 ms) : 2196, 2324
. : milestone, 2260,
profiling (2.085 ms) : 2032, 2139
. : milestone, 2085,
tracing (2.055 ms) : 2005, 2105
. : milestone, 2055,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9510177cb5, baseline=1.55.0-SNAPSHOT~cd02b0c326
dateFormat X
axisFormat %s
section baseline
no_agent (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
appsec (14.868 s) : 14868000, 14868000
. : milestone, 14868000,
iast (18.604 s) : 18604000, 18604000
. : milestone, 18604000,
iast_GLOBAL (18.047 s) : 18047000, 18047000
. : milestone, 18047000,
profiling (14.797 s) : 14797000, 14797000
. : milestone, 14797000,
tracing (14.985 s) : 14985000, 14985000
. : milestone, 14985000,
section candidate
no_agent (14.86 s) : 14860000, 14860000
. : milestone, 14860000,
appsec (15.238 s) : 15238000, 15238000
. : milestone, 15238000,
iast (18.508 s) : 18508000, 18508000
. : milestone, 18508000,
iast_GLOBAL (18.371 s) : 18371000, 18371000
. : milestone, 18371000,
profiling (15.313 s) : 15313000, 15313000
. : milestone, 15313000,
tracing (15.29 s) : 15290000, 15290000
. : milestone, 15290000,
|
What Does This Do
This PR bumps spotbugs gradle plugin to the most recent version 6.4.2 to this day (from 5.0.14).
And require a JDK 11 minimum to run.
Important
This version of spotbugs has new rules, better detection engine that requires to change so of the warnings ignores, or fix some code.
Motivation
Additional Notes
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]