add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

vandonr · 2025-10-16T09:52:51Z

What Does This Do

the JDBC instrumentation does extra calls to the DB to fetch the metadata and client info. In case this might cause issues, we want to be able to disable this behavior to reduce the instrumentation to simply creating spans.

Motivation

customer investigation

Additional Notes

missing tests for now

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: APMS-16143

datadog-official · 2025-10-16T10:10:06Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.49% (-0.22%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 9ac990b | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-10-16T10:24:53Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/jdbc-ff
git_commit_date	1761044287	1761044691
git_commit_sha	`52a8cc7`	`9ac990b`
release_version	1.55.0-SNAPSHOT~52a8cc719b	1.55.0-SNAPSHOT~9ac990be82

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761046626	1761046626
ci_job_id	1188680652	1188680652
ci_pipeline_id	79825258	79825258
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-itrn2uov 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-itrn2uov 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 61 metrics, 4 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~9ac990be82, baseline=1.55.0-SNAPSHOT~52a8cc719b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.028 s) : 0, 1028215
Total [baseline] (8.738 s) : 0, 8738321
Agent [candidate] (1.02 s) : 0, 1020269
Total [candidate] (8.671 s) : 0, 8671014
section iast
Agent [baseline] (1.161 s) : 0, 1161237
Total [baseline] (9.347 s) : 0, 9347194
Agent [candidate] (1.155 s) : 0, 1155204
Total [candidate] (9.353 s) : 0, 9352773

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.028 s	-
Agent	iast	1.161 s	133.023 ms (12.9%)
Total	tracing	8.738 s	-
Total	iast	9.347 s	608.873 ms (7.0%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	iast	1.155 s	134.935 ms (13.2%)
Total	tracing	8.671 s	-
Total	iast	9.353 s	681.759 ms (7.9%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~9ac990be82, baseline=1.55.0-SNAPSHOT~52a8cc719b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.48 ms) : 0, 1480
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (700.202 ms) : 0, 700202
BytebuddyAgent [candidate] (694.269 ms) : 0, 694269
GlobalTracer [baseline] (244.979 ms) : 0, 244979
GlobalTracer [candidate] (243.619 ms) : 0, 243619
AppSec [baseline] (32.562 ms) : 0, 32562
AppSec [candidate] (32.324 ms) : 0, 32324
Debugger [baseline] (6.37 ms) : 0, 6370
Debugger [candidate] (6.297 ms) : 0, 6297
Remote Config [baseline] (684.576 µs) : 0, 685
Remote Config [candidate] (675.204 µs) : 0, 675
Telemetry [baseline] (9.466 ms) : 0, 9466
Telemetry [candidate] (9.278 ms) : 0, 9278
Flare Poller [baseline] (11.092 ms) : 0, 11092
Flare Poller [candidate] (11.171 ms) : 0, 11171
section iast
crashtracking [baseline] (1.499 ms) : 0, 1499
crashtracking [candidate] (1.489 ms) : 0, 1489
BytebuddyAgent [baseline] (822.17 ms) : 0, 822170
BytebuddyAgent [candidate] (817.503 ms) : 0, 817503
GlobalTracer [baseline] (233.685 ms) : 0, 233685
GlobalTracer [candidate] (232.583 ms) : 0, 232583
AppSec [baseline] (35.632 ms) : 0, 35632
AppSec [candidate] (35.296 ms) : 0, 35296
Debugger [baseline] (6.166 ms) : 0, 6166
Debugger [candidate] (6.192 ms) : 0, 6192
Remote Config [baseline] (607.98 µs) : 0, 608
Remote Config [candidate] (688.023 µs) : 0, 688
Telemetry [baseline] (8.618 ms) : 0, 8618
Telemetry [candidate] (8.775 ms) : 0, 8775
Flare Poller [baseline] (4.307 ms) : 0, 4307
Flare Poller [candidate] (4.296 ms) : 0, 4296
IAST [baseline] (26.966 ms) : 0, 26966
IAST [candidate] (26.813 ms) : 0, 26813

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~9ac990be82, baseline=1.55.0-SNAPSHOT~52a8cc719b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.021 s) : 0, 1021234
Total [baseline] (10.814 s) : 0, 10813698
Agent [candidate] (1.019 s) : 0, 1019260
Total [candidate] (10.646 s) : 0, 10645909
section appsec
Agent [baseline] (1.205 s) : 0, 1205130
Total [baseline] (10.928 s) : 0, 10927962
Agent [candidate] (1.197 s) : 0, 1197428
Total [candidate] (10.858 s) : 0, 10858059
section iast
Agent [baseline] (1.157 s) : 0, 1157058
Total [baseline] (11.167 s) : 0, 11167231
Agent [candidate] (1.155 s) : 0, 1155390
Total [candidate] (11.097 s) : 0, 11096974
section profiling
Agent [baseline] (1.169 s) : 0, 1168905
Total [baseline] (10.867 s) : 0, 10867028
Agent [candidate] (1.167 s) : 0, 1166545
Total [candidate] (10.899 s) : 0, 10898998

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	appsec	1.205 s	183.896 ms (18.0%)
Agent	iast	1.157 s	135.824 ms (13.3%)
Agent	profiling	1.169 s	147.671 ms (14.5%)
Total	tracing	10.814 s	-
Total	appsec	10.928 s	114.265 ms (1.1%)
Total	iast	11.167 s	353.533 ms (3.3%)
Total	profiling	10.867 s	53.331 ms (0.5%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.019 s	-
Agent	appsec	1.197 s	178.168 ms (17.5%)
Agent	iast	1.155 s	136.13 ms (13.4%)
Agent	profiling	1.167 s	147.284 ms (14.5%)
Total	tracing	10.646 s	-
Total	appsec	10.858 s	212.15 ms (2.0%)
Total	iast	11.097 s	451.066 ms (4.2%)
Total	profiling	10.899 s	253.089 ms (2.4%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~9ac990be82, baseline=1.55.0-SNAPSHOT~52a8cc719b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.461 ms) : 0, 1461
crashtracking [candidate] (1.452 ms) : 0, 1452
BytebuddyAgent [baseline] (695.429 ms) : 0, 695429
BytebuddyAgent [candidate] (693.253 ms) : 0, 693253
GlobalTracer [baseline] (244.146 ms) : 0, 244146
GlobalTracer [candidate] (243.223 ms) : 0, 243223
AppSec [baseline] (32.214 ms) : 0, 32214
AppSec [candidate] (32.108 ms) : 0, 32108
Debugger [baseline] (6.285 ms) : 0, 6285
Debugger [candidate] (6.322 ms) : 0, 6322
Remote Config [baseline] (684.362 µs) : 0, 684
Remote Config [candidate] (674.284 µs) : 0, 674
Telemetry [baseline] (9.358 ms) : 0, 9358
Telemetry [candidate] (9.355 ms) : 0, 9355
Flare Poller [baseline] (10.315 ms) : 0, 10315
Flare Poller [candidate] (11.694 ms) : 0, 11694
section appsec
crashtracking [baseline] (1.478 ms) : 0, 1478
crashtracking [candidate] (1.45 ms) : 0, 1450
BytebuddyAgent [baseline] (725.282 ms) : 0, 725282
BytebuddyAgent [candidate] (719.432 ms) : 0, 719432
GlobalTracer [baseline] (236.625 ms) : 0, 236625
GlobalTracer [candidate] (235.865 ms) : 0, 235865
AppSec [baseline] (175.889 ms) : 0, 175889
AppSec [candidate] (175.169 ms) : 0, 175169
Debugger [baseline] (6.142 ms) : 0, 6142
Debugger [candidate] (6.106 ms) : 0, 6106
Remote Config [baseline] (637.854 µs) : 0, 638
Remote Config [candidate] (627.675 µs) : 0, 628
Telemetry [baseline] (8.626 ms) : 0, 8626
Telemetry [candidate] (8.602 ms) : 0, 8602
Flare Poller [baseline] (3.88 ms) : 0, 3880
Flare Poller [candidate] (3.933 ms) : 0, 3933
IAST [baseline] (25.272 ms) : 0, 25272
IAST [candidate] (24.979 ms) : 0, 24979
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.453 ms) : 0, 1453
BytebuddyAgent [baseline] (819.092 ms) : 0, 819092
BytebuddyAgent [candidate] (817.279 ms) : 0, 817279
GlobalTracer [baseline] (233.012 ms) : 0, 233012
GlobalTracer [candidate] (232.872 ms) : 0, 232872
AppSec [baseline] (35.39 ms) : 0, 35390
AppSec [candidate] (35.371 ms) : 0, 35371
Debugger [baseline] (6.191 ms) : 0, 6191
Debugger [candidate] (6.229 ms) : 0, 6229
Remote Config [baseline] (613.831 µs) : 0, 614
Remote Config [candidate] (603.367 µs) : 0, 603
Telemetry [baseline] (8.712 ms) : 0, 8712
Telemetry [candidate] (8.745 ms) : 0, 8745
Flare Poller [baseline] (4.29 ms) : 0, 4290
Flare Poller [candidate] (4.363 ms) : 0, 4363
IAST [baseline] (26.624 ms) : 0, 26624
IAST [candidate] (26.863 ms) : 0, 26863
section profiling
crashtracking [baseline] (1.481 ms) : 0, 1481
crashtracking [candidate] (1.477 ms) : 0, 1477
BytebuddyAgent [baseline] (722.585 ms) : 0, 722585
BytebuddyAgent [candidate] (721.707 ms) : 0, 721707
GlobalTracer [baseline] (219.91 ms) : 0, 219910
GlobalTracer [candidate] (219.552 ms) : 0, 219552
AppSec [baseline] (32.459 ms) : 0, 32459
AppSec [candidate] (32.284 ms) : 0, 32284
Debugger [baseline] (6.737 ms) : 0, 6737
Debugger [candidate] (6.655 ms) : 0, 6655
Remote Config [baseline] (710.418 µs) : 0, 710
Remote Config [candidate] (686.553 µs) : 0, 687
Telemetry [baseline] (15.993 ms) : 0, 15993
Telemetry [candidate] (16.134 ms) : 0, 16134
Flare Poller [baseline] (4.161 ms) : 0, 4161
Flare Poller [candidate] (4.15 ms) : 0, 4150
ProfilingAgent [baseline] (110.817 ms) : 0, 110817
ProfilingAgent [candidate] (109.868 ms) : 0, 109868
Profiling [baseline] (111.452 ms) : 0, 111452
Profiling [candidate] (110.522 ms) : 0, 110522

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/jdbc-ff
git_commit_date	1761044287	1761044691
git_commit_sha	`52a8cc7`	`9ac990b`
release_version	1.55.0-SNAPSHOT~52a8cc719b	1.55.0-SNAPSHOT~9ac990be82

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761046296	1761046296
ci_job_id	1188680653	1188680653
ci_pipeline_id	79825258	79825258
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-6dyqhub8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-6dyqhub8 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 5 performance improvements and 1 performance regressions! Performance is the same for 6 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:no_agent:high_load	better [-211.868µs; -98.803µs] or [-4.540%; -2.117%]	unstable [-74.986op/s; +141.361op/s] or [-7.613%; +14.351%]	4.511ms	1018.219op/s	4.667ms	985.031op/s
scenario:load:insecure-bank:tracing:high_load	better [-821.672µs; -548.480µs] or [-9.540%; -6.368%]	unstable [-20.989op/s; +112.677op/s] or [-3.898%; +20.924%]	7.928ms	584.344op/s	8.613ms	538.500op/s
scenario:load:insecure-bank:iast_FULL:high_load	worse [+366.722µs; +969.237µs] or [+2.649%; +7.002%]	unstable [-51.291op/s; +20.354op/s] or [-15.240%; +6.048%]	14.510ms	321.094op/s	13.842ms	336.562op/s
scenario:load:petclinic:profiling:high_load	better [-2.829ms; -1.869ms] or [-5.627%; -3.717%]	unstable [-2.599op/s; +11.599op/s] or [-2.791%; +12.452%]	47.928ms	97.650op/s	50.277ms	93.150op/s
scenario:load:petclinic:appsec:high_load	better [-4.738ms; -3.821ms] or [-9.356%; -7.545%]	unstable [+1.502op/s; +15.523op/s] or [+1.625%; +16.793%]	46.363ms	100.950op/s	50.643ms	92.438op/s
scenario:load:petclinic:code_origins:high_load	better [-2.035ms; -1.241ms] or [-4.591%; -2.799%]	unstable [-3.267op/s; +11.467op/s] or [-3.097%; +10.868%]	42.697ms	109.612op/s	44.335ms	105.513op/s

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9ac990be82, baseline=1.55.0-SNAPSHOT~52a8cc719b
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.667 ms) : 4612, 4721
.   : milestone, 4667,
iast (9.823 ms) : 9656, 9991
.   : milestone, 9823,
iast_FULL (13.842 ms) : 13573, 14112
.   : milestone, 13842,
iast_GLOBAL (10.456 ms) : 10266, 10646
.   : milestone, 10456,
profiling (9.13 ms) : 8971, 9290
.   : milestone, 9130,
tracing (8.613 ms) : 8475, 8750
.   : milestone, 8613,
section candidate
no_agent (4.511 ms) : 4460, 4562
.   : milestone, 4511,
iast (9.728 ms) : 9558, 9898
.   : milestone, 9728,
iast_FULL (14.51 ms) : 14220, 14800
.   : milestone, 14510,
iast_GLOBAL (10.209 ms) : 10031, 10388
.   : milestone, 10209,
profiling (9.085 ms) : 8931, 9239
.   : milestone, 9085,
tracing (7.928 ms) : 7812, 8043
.   : milestone, 7928,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.667 ms [4.612 ms, 4.721 ms]	-
iast	9.823 ms [9.656 ms, 9.991 ms]	5.157 ms (110.5%)
iast_FULL	13.842 ms [13.573 ms, 14.112 ms]	9.176 ms (196.6%)
iast_GLOBAL	10.456 ms [10.266 ms, 10.646 ms]	5.79 ms (124.1%)
profiling	9.13 ms [8.971 ms, 9.29 ms]	4.464 ms (95.7%)
tracing	8.613 ms [8.475 ms, 8.75 ms]	3.946 ms (84.6%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.511 ms [4.46 ms, 4.562 ms]	-
iast	9.728 ms [9.558 ms, 9.898 ms]	5.217 ms (115.6%)
iast_FULL	14.51 ms [14.22 ms, 14.8 ms]	9.999 ms (221.6%)
iast_GLOBAL	10.209 ms [10.031 ms, 10.388 ms]	5.698 ms (126.3%)
profiling	9.085 ms [8.931 ms, 9.239 ms]	4.574 ms (101.4%)
tracing	7.928 ms [7.812 ms, 8.043 ms]	3.416 ms (75.7%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~9ac990be82, baseline=1.55.0-SNAPSHOT~52a8cc719b
    dateFormat X
    axisFormat %s
section baseline
no_agent (38.018 ms) : 37721, 38315
.   : milestone, 38018,
appsec (50.643 ms) : 50201, 51085
.   : milestone, 50643,
code_origins (44.335 ms) : 43951, 44719
.   : milestone, 44335,
iast (45.413 ms) : 45014, 45813
.   : milestone, 45413,
profiling (50.277 ms) : 49825, 50729
.   : milestone, 50277,
tracing (44.418 ms) : 44036, 44800
.   : milestone, 44418,
section candidate
no_agent (37.636 ms) : 37343, 37928
.   : milestone, 37636,
appsec (46.363 ms) : 45954, 46773
.   : milestone, 46363,
code_origins (42.697 ms) : 42343, 43050
.   : milestone, 42697,
iast (44.605 ms) : 44222, 44989
.   : milestone, 44605,
profiling (47.928 ms) : 47487, 48369
.   : milestone, 47928,
tracing (43.634 ms) : 43260, 44009
.   : milestone, 43634,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.018 ms [37.721 ms, 38.315 ms]	-
appsec	50.643 ms [50.201 ms, 51.085 ms]	12.625 ms (33.2%)
code_origins	44.335 ms [43.951 ms, 44.719 ms]	6.317 ms (16.6%)
iast	45.413 ms [45.014 ms, 45.813 ms]	7.395 ms (19.5%)
profiling	50.277 ms [49.825 ms, 50.729 ms]	12.259 ms (32.2%)
tracing	44.418 ms [44.036 ms, 44.8 ms]	6.4 ms (16.8%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	37.636 ms [37.343 ms, 37.928 ms]	-
appsec	46.363 ms [45.954 ms, 46.773 ms]	8.728 ms (23.2%)
code_origins	42.697 ms [42.343 ms, 43.05 ms]	5.061 ms (13.4%)
iast	44.605 ms [44.222 ms, 44.989 ms]	6.97 ms (18.5%)
profiling	47.928 ms [47.487 ms, 48.369 ms]	10.292 ms (27.3%)
tracing	43.634 ms [43.26 ms, 44.009 ms]	5.999 ms (15.9%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	vandonr/jdbc-ff
git_commit_date	1761044287	1761044691
git_commit_sha	`52a8cc7`	`9ac990b`
release_version	1.55.0-SNAPSHOT~52a8cc719b	1.55.0-SNAPSHOT~9ac990be82

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1761046934	1761046934
ci_job_id	1188680654	1188680654
ci_pipeline_id	79825258	79825258
cpu_model	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-1-wj7ye715 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-1-wj7ye715 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9ac990be82, baseline=1.55.0-SNAPSHOT~52a8cc719b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.49 ms) : 1478, 1502
.   : milestone, 1490,
appsec (4.197 ms) : 3945, 4449
.   : milestone, 4197,
iast (2.568 ms) : 2468, 2668
.   : milestone, 2568,
iast_GLOBAL (2.632 ms) : 2530, 2733
.   : milestone, 2632,
profiling (2.424 ms) : 2337, 2511
.   : milestone, 2424,
tracing (2.365 ms) : 2283, 2447
.   : milestone, 2365,
section candidate
no_agent (1.486 ms) : 1475, 1498
.   : milestone, 1486,
appsec (4.185 ms) : 3934, 4436
.   : milestone, 4185,
iast (2.57 ms) : 2469, 2670
.   : milestone, 2570,
iast_GLOBAL (2.622 ms) : 2521, 2723
.   : milestone, 2622,
profiling (2.413 ms) : 2327, 2500
.   : milestone, 2413,
tracing (2.35 ms) : 2268, 2432
.   : milestone, 2350,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.49 ms [1.478 ms, 1.502 ms]	-
appsec	4.197 ms [3.945 ms, 4.449 ms]	2.707 ms (181.7%)
iast	2.568 ms [2.468 ms, 2.668 ms]	1.078 ms (72.4%)
iast_GLOBAL	2.632 ms [2.53 ms, 2.733 ms]	1.142 ms (76.6%)
profiling	2.424 ms [2.337 ms, 2.511 ms]	934.452 µs (62.7%)
tracing	2.365 ms [2.283 ms, 2.447 ms]	875.048 µs (58.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.486 ms [1.475 ms, 1.498 ms]	-
appsec	4.185 ms [3.934 ms, 4.436 ms]	2.698 ms (181.5%)
iast	2.57 ms [2.469 ms, 2.67 ms]	1.083 ms (72.9%)
iast_GLOBAL	2.622 ms [2.521 ms, 2.723 ms]	1.136 ms (76.4%)
profiling	2.413 ms [2.327 ms, 2.5 ms]	926.677 µs (62.3%)
tracing	2.35 ms [2.268 ms, 2.432 ms]	863.728 µs (58.1%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~9ac990be82, baseline=1.55.0-SNAPSHOT~52a8cc719b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.245 s) : 15245000, 15245000
.   : milestone, 15245000,
appsec (14.582 s) : 14582000, 14582000
.   : milestone, 14582000,
iast (18.013 s) : 18013000, 18013000
.   : milestone, 18013000,
iast_GLOBAL (17.634 s) : 17634000, 17634000
.   : milestone, 17634000,
profiling (14.471 s) : 14471000, 14471000
.   : milestone, 14471000,
tracing (14.687 s) : 14687000, 14687000
.   : milestone, 14687000,
section candidate
no_agent (14.925 s) : 14925000, 14925000
.   : milestone, 14925000,
appsec (14.545 s) : 14545000, 14545000
.   : milestone, 14545000,
iast (17.842 s) : 17842000, 17842000
.   : milestone, 17842000,
iast_GLOBAL (17.634 s) : 17634000, 17634000
.   : milestone, 17634000,
profiling (14.484 s) : 14484000, 14484000
.   : milestone, 14484000,
tracing (14.643 s) : 14643000, 14643000
.   : milestone, 14643000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.245 s [15.245 s, 15.245 s]	-
appsec	14.582 s [14.582 s, 14.582 s]	-663.0 ms (-4.3%)
iast	18.013 s [18.013 s, 18.013 s]	2.768 s (18.2%)
iast_GLOBAL	17.634 s [17.634 s, 17.634 s]	2.389 s (15.7%)
profiling	14.471 s [14.471 s, 14.471 s]	-774.0 ms (-5.1%)
tracing	14.687 s [14.687 s, 14.687 s]	-558.0 ms (-3.7%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.925 s [14.925 s, 14.925 s]	-
appsec	14.545 s [14.545 s, 14.545 s]	-380.0 ms (-2.5%)
iast	17.842 s [17.842 s, 17.842 s]	2.917 s (19.5%)
iast_GLOBAL	17.634 s [17.634 s, 17.634 s]	2.709 s (18.2%)
profiling	14.484 s [14.484 s, 14.484 s]	-441.0 ms (-3.0%)
tracing	14.643 s [14.643 s, 14.643 s]	-282.0 ms (-1.9%)

internal-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy

AlexeyKuznetsov-DD · 2025-10-16T13:11:56Z

...ent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/JDBCDecorator.java

+          try {
+            clientInfo = connection.getClientInfo();
+          } catch (final Throwable ex) {
+            // getClientInfo is likely not allowed, we can still extract info from the url alone


Maybe make sense to put some debug/trace log? Just thinking out loud.

you mean for investigation in the current case, or in general ?

I think it could help for investigation in the current case! I have no scale for how often this method is called though -- would adding debug statements here be "okay" in a production environment where we don't want to spam logs?

added a log, we'll need to make sure this is not merged to main if we want to keep the feature flags for further investigations

Cool thanks! I'll add a do not merge tag for now to remind us

AlexeyKuznetsov-DD

LGTM

vandonr added 2 commits October 16, 2025 10:57

add config flags but in the wrong place

e29146f

move flags

a685b20

vandonr added type: feature request inst: jdbc JDBC instrumentation labels Oct 16, 2025

AlexeyKuznetsov-DD reviewed Oct 16, 2025

View reviewed changes

internal-api/src/test/groovy/datadog/trace/api/ConfigTest.groovy Outdated Show resolved Hide resolved

AlexeyKuznetsov-DD reviewed Oct 16, 2025

View reviewed changes

AlexeyKuznetsov-DD approved these changes Oct 16, 2025

View reviewed changes

vandonr added 4 commits October 16, 2025 17:02

read config only once

1b7f677

remove spotless:off comment

cd6e512

add test

ea2c982

add debug logs in error cases

4a1d0cb

sarahchen6 added the tag: do not merge Do not merge changes label Oct 20, 2025

Merge remote-tracking branch 'origin/master' into vandonr/jdbc-ff

9ac990b

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

Uh oh!

vandonr commented Oct 16, 2025 •

edited by atlassian bot

Loading

Uh oh!

datadog-official bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

pr-commenter bot commented Oct 16, 2025 •

edited

Loading

Uh oh!

Uh oh!

AlexeyKuznetsov-DD Oct 16, 2025

Uh oh!

vandonr Oct 16, 2025

Uh oh!

sarahchen6 Oct 17, 2025

Uh oh!

vandonr Oct 20, 2025

Uh oh!

sarahchen6 Oct 20, 2025

Uh oh!

AlexeyKuznetsov-DD left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

Are you sure you want to change the base?

add a feature flag to disable extra calls to the DB in JDBC instrumentation #9774

Uh oh!

Conversation

vandonr commented Oct 16, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

datadog-official bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

Uh oh!

AlexeyKuznetsov-DD Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

vandonr Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

sarahchen6 Oct 17, 2025

Choose a reason for hiding this comment

Uh oh!

vandonr Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

sarahchen6 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

AlexeyKuznetsov-DD left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vandonr commented Oct 16, 2025 •

edited by atlassian bot

Loading

datadog-official bot commented Oct 16, 2025 •

edited

Loading

pr-commenter bot commented Oct 16, 2025 •

edited

Loading