-
Notifications
You must be signed in to change notification settings - Fork 314
Limit writer logs only when LLMObs is enabled #9781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics. Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~3d0bf41bfd, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1017139
Total [baseline] (10.67 s) : 0, 10670474
Agent [candidate] (1.014 s) : 0, 1014395
Total [candidate] (10.65 s) : 0, 10650241
section appsec
Agent [baseline] (1.191 s) : 0, 1191015
Total [baseline] (10.76 s) : 0, 10760213
Agent [candidate] (1.194 s) : 0, 1194216
Total [candidate] (10.801 s) : 0, 10801204
section iast
Agent [baseline] (1.155 s) : 0, 1155345
Total [baseline] (11.11 s) : 0, 11110235
Agent [candidate] (1.149 s) : 0, 1149465
Total [candidate] (11.064 s) : 0, 11064408
section profiling
Agent [baseline] (1.158 s) : 0, 1158286
Total [baseline] (10.821 s) : 0, 10820981
Agent [candidate] (1.164 s) : 0, 1163644
Total [candidate] (10.815 s) : 0, 10814512
gantt
title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~3d0bf41bfd, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (691.951 ms) : 0, 691951
BytebuddyAgent [candidate] (690.794 ms) : 0, 690794
GlobalTracer [baseline] (242.652 ms) : 0, 242652
GlobalTracer [candidate] (242.153 ms) : 0, 242153
AppSec [baseline] (32.577 ms) : 0, 32577
AppSec [candidate] (32.376 ms) : 0, 32376
Debugger [baseline] (6.346 ms) : 0, 6346
Debugger [candidate] (6.358 ms) : 0, 6358
Remote Config [baseline] (682.24 µs) : 0, 682
Remote Config [candidate] (676.851 µs) : 0, 677
Telemetry [baseline] (9.401 ms) : 0, 9401
Telemetry [candidate] (9.48 ms) : 0, 9480
Flare Poller [baseline] (10.98 ms) : 0, 10980
Flare Poller [candidate] (9.983 ms) : 0, 9983
section appsec
crashtracking [baseline] (1.459 ms) : 0, 1459
crashtracking [candidate] (1.466 ms) : 0, 1466
BytebuddyAgent [baseline] (715.507 ms) : 0, 715507
BytebuddyAgent [candidate] (717.747 ms) : 0, 717747
GlobalTracer [baseline] (234.417 ms) : 0, 234417
GlobalTracer [candidate] (235.038 ms) : 0, 235038
IAST [baseline] (24.712 ms) : 0, 24712
IAST [candidate] (24.757 ms) : 0, 24757
AppSec [baseline] (174.509 ms) : 0, 174509
AppSec [candidate] (175.051 ms) : 0, 175051
Debugger [baseline] (6.141 ms) : 0, 6141
Debugger [candidate] (6.04 ms) : 0, 6040
Remote Config [baseline] (663.728 µs) : 0, 664
Remote Config [candidate] (630.236 µs) : 0, 630
Telemetry [baseline] (8.619 ms) : 0, 8619
Telemetry [candidate] (8.48 ms) : 0, 8480
Flare Poller [baseline] (3.925 ms) : 0, 3925
Flare Poller [candidate] (3.936 ms) : 0, 3936
section iast
crashtracking [baseline] (1.485 ms) : 0, 1485
crashtracking [candidate] (1.459 ms) : 0, 1459
BytebuddyAgent [baseline] (818.886 ms) : 0, 818886
BytebuddyAgent [candidate] (812.991 ms) : 0, 812991
GlobalTracer [baseline] (232.059 ms) : 0, 232059
GlobalTracer [candidate] (232.201 ms) : 0, 232201
IAST [baseline] (26.47 ms) : 0, 26470
IAST [candidate] (26.501 ms) : 0, 26501
AppSec [baseline] (35.012 ms) : 0, 35012
AppSec [candidate] (35.267 ms) : 0, 35267
Debugger [baseline] (6.21 ms) : 0, 6210
Debugger [candidate] (6.128 ms) : 0, 6128
Remote Config [baseline] (608.062 µs) : 0, 608
Remote Config [candidate] (597.525 µs) : 0, 598
Telemetry [baseline] (8.687 ms) : 0, 8687
Telemetry [candidate] (8.651 ms) : 0, 8651
Flare Poller [baseline] (4.308 ms) : 0, 4308
Flare Poller [candidate] (4.226 ms) : 0, 4226
section profiling
crashtracking [baseline] (1.437 ms) : 0, 1437
crashtracking [candidate] (1.428 ms) : 0, 1428
BytebuddyAgent [baseline] (718.149 ms) : 0, 718149
BytebuddyAgent [candidate] (722.139 ms) : 0, 722139
GlobalTracer [baseline] (218.078 ms) : 0, 218078
GlobalTracer [candidate] (219.131 ms) : 0, 219131
AppSec [baseline] (32.028 ms) : 0, 32028
AppSec [candidate] (32.404 ms) : 0, 32404
Debugger [baseline] (6.622 ms) : 0, 6622
Debugger [candidate] (7.585 ms) : 0, 7585
Remote Config [baseline] (692.183 µs) : 0, 692
Remote Config [candidate] (692.733 µs) : 0, 693
Telemetry [baseline] (15.271 ms) : 0, 15271
Telemetry [candidate] (15.083 ms) : 0, 15083
Flare Poller [baseline] (4.95 ms) : 0, 4950
Flare Poller [candidate] (4.081 ms) : 0, 4081
ProfilingAgent [baseline] (106.832 ms) : 0, 106832
ProfilingAgent [candidate] (106.858 ms) : 0, 106858
Profiling [baseline] (109.117 ms) : 0, 109117
Profiling [candidate] (108.894 ms) : 0, 108894
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~3d0bf41bfd, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.017 s) : 0, 1016812
Total [baseline] (8.632 s) : 0, 8631942
Agent [candidate] (1.018 s) : 0, 1017548
Total [candidate] (8.62 s) : 0, 8620304
section iast
Agent [baseline] (1.152 s) : 0, 1152094
Total [baseline] (9.321 s) : 0, 9321332
Agent [candidate] (1.161 s) : 0, 1161241
Total [candidate] (9.295 s) : 0, 9294858
gantt
title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~3d0bf41bfd, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.474 ms) : 0, 1474
crashtracking [candidate] (1.465 ms) : 0, 1465
BytebuddyAgent [baseline] (692.483 ms) : 0, 692483
BytebuddyAgent [candidate] (692.26 ms) : 0, 692260
GlobalTracer [baseline] (241.903 ms) : 0, 241903
GlobalTracer [candidate] (242.516 ms) : 0, 242516
AppSec [baseline] (32.344 ms) : 0, 32344
AppSec [candidate] (32.365 ms) : 0, 32365
Debugger [baseline] (6.389 ms) : 0, 6389
Debugger [candidate] (6.345 ms) : 0, 6345
Remote Config [baseline] (679.092 µs) : 0, 679
Remote Config [candidate] (665.409 µs) : 0, 665
Telemetry [baseline] (9.39 ms) : 0, 9390
Telemetry [candidate] (9.418 ms) : 0, 9418
Flare Poller [baseline] (11.151 ms) : 0, 11151
Flare Poller [candidate] (11.534 ms) : 0, 11534
section iast
crashtracking [baseline] (1.489 ms) : 0, 1489
crashtracking [candidate] (1.501 ms) : 0, 1501
BytebuddyAgent [baseline] (814.292 ms) : 0, 814292
BytebuddyAgent [candidate] (822.099 ms) : 0, 822099
GlobalTracer [baseline] (232.735 ms) : 0, 232735
GlobalTracer [candidate] (234.05 ms) : 0, 234050
AppSec [baseline] (35.355 ms) : 0, 35355
AppSec [candidate] (35.051 ms) : 0, 35051
Debugger [baseline] (6.251 ms) : 0, 6251
Debugger [candidate] (6.299 ms) : 0, 6299
Remote Config [baseline] (610.657 µs) : 0, 611
Remote Config [candidate] (611.667 µs) : 0, 612
Telemetry [baseline] (8.887 ms) : 0, 8887
Telemetry [candidate] (8.768 ms) : 0, 8768
Flare Poller [baseline] (4.253 ms) : 0, 4253
Flare Poller [candidate] (4.285 ms) : 0, 4285
IAST [baseline] (26.798 ms) : 0, 26798
IAST [candidate] (26.998 ms) : 0, 26998
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 9 metrics, 12 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~3d0bf41bfd, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section baseline
no_agent (4.319 ms) : 4272, 4366
. : milestone, 4319,
iast (10.042 ms) : 9873, 10212
. : milestone, 10042,
iast_FULL (14.689 ms) : 14399, 14979
. : milestone, 14689,
iast_GLOBAL (10.943 ms) : 10743, 11142
. : milestone, 10943,
profiling (8.678 ms) : 8545, 8810
. : milestone, 8678,
tracing (7.653 ms) : 7543, 7762
. : milestone, 7653,
section candidate
no_agent (4.369 ms) : 4319, 4418
. : milestone, 4369,
iast (9.565 ms) : 9402, 9728
. : milestone, 9565,
iast_FULL (15.641 ms) : 15334, 15949
. : milestone, 15641,
iast_GLOBAL (10.752 ms) : 10560, 10944
. : milestone, 10752,
profiling (8.674 ms) : 8534, 8814
. : milestone, 8674,
tracing (7.878 ms) : 7746, 8010
. : milestone, 7878,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~3d0bf41bfd, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section baseline
no_agent (36.956 ms) : 36667, 37245
. : milestone, 36956,
appsec (46.201 ms) : 45796, 46605
. : milestone, 46201,
code_origins (43.055 ms) : 42691, 43419
. : milestone, 43055,
iast (42.544 ms) : 42182, 42906
. : milestone, 42544,
profiling (47.666 ms) : 47229, 48102
. : milestone, 47666,
tracing (44.163 ms) : 43785, 44540
. : milestone, 44163,
section candidate
no_agent (36.572 ms) : 36283, 36862
. : milestone, 36572,
appsec (49.56 ms) : 49106, 50015
. : milestone, 49560,
code_origins (43.646 ms) : 43283, 44009
. : milestone, 43646,
iast (43.443 ms) : 43073, 43812
. : milestone, 43443,
profiling (48.032 ms) : 47565, 48500
. : milestone, 48032,
tracing (43.223 ms) : 42856, 43589
. : milestone, 43223,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~3d0bf41bfd, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section baseline
no_agent (14.959 s) : 14959000, 14959000
. : milestone, 14959000,
appsec (14.966 s) : 14966000, 14966000
. : milestone, 14966000,
iast (18.393 s) : 18393000, 18393000
. : milestone, 18393000,
iast_GLOBAL (18.089 s) : 18089000, 18089000
. : milestone, 18089000,
profiling (15.233 s) : 15233000, 15233000
. : milestone, 15233000,
tracing (15.181 s) : 15181000, 15181000
. : milestone, 15181000,
section candidate
no_agent (15.4 s) : 15400000, 15400000
. : milestone, 15400000,
appsec (15.038 s) : 15038000, 15038000
. : milestone, 15038000,
iast (18.692 s) : 18692000, 18692000
. : milestone, 18692000,
iast_GLOBAL (18.033 s) : 18033000, 18033000
. : milestone, 18033000,
profiling (15.252 s) : 15252000, 15252000
. : milestone, 15252000,
tracing (15.262 s) : 15262000, 15262000
. : milestone, 15262000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~3d0bf41bfd, baseline=1.55.0-SNAPSHOT~33e27c7cea
dateFormat X
axisFormat %s
section baseline
no_agent (1.489 ms) : 1477, 1501
. : milestone, 1489,
appsec (3.68 ms) : 3465, 3894
. : milestone, 3680,
iast (2.224 ms) : 2160, 2287
. : milestone, 2224,
iast_GLOBAL (2.273 ms) : 2209, 2337
. : milestone, 2273,
profiling (2.064 ms) : 2013, 2115
. : milestone, 2064,
tracing (2.033 ms) : 1984, 2083
. : milestone, 2033,
section candidate
no_agent (1.481 ms) : 1470, 1493
. : milestone, 1481,
appsec (3.728 ms) : 3509, 3947
. : milestone, 3728,
iast (2.232 ms) : 2168, 2296
. : milestone, 2232,
iast_GLOBAL (2.268 ms) : 2203, 2332
. : milestone, 2268,
profiling (2.073 ms) : 2021, 2124
. : milestone, 2073,
tracing (2.047 ms) : 1997, 2097
. : milestone, 2047,
|
🎯 Code Coverage 🔗 Commit SHA: 3d0bf41 | Docs | Was this helpful? Give us feedback! |
boolean useProxyApi = false; | ||
|
||
if (TrackType.LLMOBS == trackType) { | ||
useProxyApi = evpProxySupported && !config.isLlmObsAgentlessEnabled(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The !config.isLlmObsAgentlessEnabled()
check can be done once for clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
What Does This Do
Motivation
The logging was performed whenever EVP Proxy was not supported, independently of LLM Obs being enabled or not.
Contributor Checklist
type:
and (comp:
orinst:
) labels in addition to any useful labelsclose
,fix
or any linking keywords when referencing an issue.Use
solves
instead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]