Rename request body sample rate config variable #9791

manuel-alvarez-alvarez · 2025-10-17T10:22:17Z

What Does This Do

Renames the sample rate config variable from api-security.downstream.request.analysis.sample_rate to api-security.downstream.request.body.analysis.sample_rate.

Motivation

Due to an issue in the RFC, both variable names were listed. Tracers should use api-security.downstream.request.body.analysis.sample_rate.

Additional Notes

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any useful labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the CODEOWNERS file on source file addition, move, or deletion
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

jandro996

Do we know if any user is actually using the old env variable? I guess not, since it was released in the last version and probably isn’t in the public docs. Might be worth keeping both variables for now, just in case? I assume the answer is no, but just wanted to flag it in case you hadn’t considered it 🙂

datadog-official · 2025-10-17T10:40:54Z

🎯 Code Coverage
• Patch Coverage: 0.00%
• Total Coverage: 59.49% (-0.22%)

View detailed report

_{This comment will be updated automatically if new data arrives.

🔗 Commit SHA: 4cc6b68 | Docs | Was this helpful? Give us feedback!}

pr-commenter · 2025-10-17T11:36:04Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-api10-sampling-config
git_commit_date	1760967512	1761033164
git_commit_sha	`fb31324`	`4cc6b68`
release_version	1.55.0-SNAPSHOT~fb3132475b	1.55.0-SNAPSHOT~4cc6b680f6

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761035029	1761035029
ci_job_id	1188366883	1188366883
ci_pipeline_id	79812521	79812521
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-tqy1jlhw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-tqy1jlhw 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 59 metrics, 6 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.55.0-SNAPSHOT~4cc6b680f6, baseline=1.55.0-SNAPSHOT~fb3132475b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.019 s) : 0, 1018903
Total [baseline] (8.632 s) : 0, 8631829
Agent [candidate] (1.021 s) : 0, 1021091
Total [candidate] (8.646 s) : 0, 8645658
section iast
Agent [baseline] (1.167 s) : 0, 1166897
Total [baseline] (9.301 s) : 0, 9300763
Agent [candidate] (1.15 s) : 0, 1150101
Total [candidate] (9.28 s) : 0, 9280429

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.019 s	-
Agent	iast	1.167 s	147.994 ms (14.5%)
Total	tracing	8.632 s	-
Total	iast	9.301 s	668.934 ms (7.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.021 s	-
Agent	iast	1.15 s	129.01 ms (12.6%)
Total	tracing	8.646 s	-
Total	iast	9.28 s	634.772 ms (7.3%)

gantt
    title insecure-bank - break down per module: candidate=1.55.0-SNAPSHOT~4cc6b680f6, baseline=1.55.0-SNAPSHOT~fb3132475b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.458 ms) : 0, 1458
crashtracking [candidate] (1.47 ms) : 0, 1470
BytebuddyAgent [baseline] (694.155 ms) : 0, 694155
BytebuddyAgent [candidate] (694.475 ms) : 0, 694475
GlobalTracer [baseline] (242.671 ms) : 0, 242671
GlobalTracer [candidate] (243.536 ms) : 0, 243536
AppSec [baseline] (32.164 ms) : 0, 32164
AppSec [candidate] (32.198 ms) : 0, 32198
Debugger [baseline] (6.277 ms) : 0, 6277
Debugger [candidate] (6.288 ms) : 0, 6288
Remote Config [baseline] (682.763 µs) : 0, 683
Remote Config [candidate] (670.143 µs) : 0, 670
Telemetry [baseline] (9.35 ms) : 0, 9350
Telemetry [candidate] (9.35 ms) : 0, 9350
Flare Poller [baseline] (11.058 ms) : 0, 11058
Flare Poller [candidate] (12.003 ms) : 0, 12003
section iast
crashtracking [baseline] (1.505 ms) : 0, 1505
crashtracking [candidate] (1.485 ms) : 0, 1485
BytebuddyAgent [baseline] (827.146 ms) : 0, 827146
BytebuddyAgent [candidate] (813.94 ms) : 0, 813940
GlobalTracer [baseline] (233.969 ms) : 0, 233969
GlobalTracer [candidate] (231.384 ms) : 0, 231384
AppSec [baseline] (35.531 ms) : 0, 35531
AppSec [candidate] (35.295 ms) : 0, 35295
Debugger [baseline] (6.134 ms) : 0, 6134
Debugger [candidate] (6.163 ms) : 0, 6163
Remote Config [baseline] (608.838 µs) : 0, 609
Remote Config [candidate] (597.921 µs) : 0, 598
Telemetry [baseline] (8.699 ms) : 0, 8699
Telemetry [candidate] (8.746 ms) : 0, 8746
Flare Poller [baseline] (4.42 ms) : 0, 4420
Flare Poller [candidate] (4.333 ms) : 0, 4333
IAST [baseline] (27.213 ms) : 0, 27213
IAST [candidate] (26.838 ms) : 0, 26838

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.55.0-SNAPSHOT~4cc6b680f6, baseline=1.55.0-SNAPSHOT~fb3132475b

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.02 s) : 0, 1019992
Total [baseline] (10.639 s) : 0, 10639193
Agent [candidate] (1.025 s) : 0, 1025041
Total [candidate] (10.623 s) : 0, 10623416
section appsec
Agent [baseline] (1.2 s) : 0, 1200152
Total [baseline] (10.825 s) : 0, 10825448
Agent [candidate] (1.197 s) : 0, 1197201
Total [candidate] (10.8 s) : 0, 10800020
section iast
Agent [baseline] (1.152 s) : 0, 1152344
Total [baseline] (11.063 s) : 0, 11063125
Agent [candidate] (1.152 s) : 0, 1151747
Total [candidate] (11.092 s) : 0, 11092328
section profiling
Agent [baseline] (1.164 s) : 0, 1163954
Total [baseline] (10.811 s) : 0, 10811347
Agent [candidate] (1.161 s) : 0, 1161002
Total [candidate] (10.837 s) : 0, 10836685

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.02 s	-
Agent	appsec	1.2 s	180.159 ms (17.7%)
Agent	iast	1.152 s	132.351 ms (13.0%)
Agent	profiling	1.164 s	143.962 ms (14.1%)
Total	tracing	10.639 s	-
Total	appsec	10.825 s	186.255 ms (1.8%)
Total	iast	11.063 s	423.931 ms (4.0%)
Total	profiling	10.811 s	172.154 ms (1.6%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.025 s	-
Agent	appsec	1.197 s	172.16 ms (16.8%)
Agent	iast	1.152 s	126.705 ms (12.4%)
Agent	profiling	1.161 s	135.961 ms (13.3%)
Total	tracing	10.623 s	-
Total	appsec	10.8 s	176.603 ms (1.7%)
Total	iast	11.092 s	468.912 ms (4.4%)
Total	profiling	10.837 s	213.269 ms (2.0%)

gantt
    title petclinic - break down per module: candidate=1.55.0-SNAPSHOT~4cc6b680f6, baseline=1.55.0-SNAPSHOT~fb3132475b

    dateFormat X
    axisFormat %s
section tracing
crashtracking [baseline] (1.464 ms) : 0, 1464
crashtracking [candidate] (1.458 ms) : 0, 1458
BytebuddyAgent [baseline] (693.62 ms) : 0, 693620
BytebuddyAgent [candidate] (699.126 ms) : 0, 699126
GlobalTracer [baseline] (243.454 ms) : 0, 243454
GlobalTracer [candidate] (244.593 ms) : 0, 244593
AppSec [baseline] (32.558 ms) : 0, 32558
AppSec [candidate] (32.503 ms) : 0, 32503
Debugger [baseline] (6.349 ms) : 0, 6349
Debugger [candidate] (6.381 ms) : 0, 6381
Remote Config [baseline] (677.126 µs) : 0, 677
Remote Config [candidate] (687.651 µs) : 0, 688
Telemetry [baseline] (9.391 ms) : 0, 9391
Telemetry [candidate] (9.432 ms) : 0, 9432
Flare Poller [baseline] (11.27 ms) : 0, 11270
Flare Poller [candidate] (9.69 ms) : 0, 9690
section appsec
crashtracking [baseline] (1.469 ms) : 0, 1469
crashtracking [candidate] (1.464 ms) : 0, 1464
BytebuddyAgent [baseline] (721.976 ms) : 0, 721976
BytebuddyAgent [candidate] (720.821 ms) : 0, 720821
GlobalTracer [baseline] (235.872 ms) : 0, 235872
GlobalTracer [candidate] (234.636 ms) : 0, 234636
AppSec [baseline] (175.407 ms) : 0, 175407
AppSec [candidate] (174.989 ms) : 0, 174989
Debugger [baseline] (6.091 ms) : 0, 6091
Debugger [candidate] (6.109 ms) : 0, 6109
Remote Config [baseline] (641.425 µs) : 0, 641
Remote Config [candidate] (623.72 µs) : 0, 624
Telemetry [baseline] (8.633 ms) : 0, 8633
Telemetry [candidate] (8.488 ms) : 0, 8488
Flare Poller [baseline] (3.863 ms) : 0, 3863
Flare Poller [candidate] (3.868 ms) : 0, 3868
IAST [baseline] (24.969 ms) : 0, 24969
IAST [candidate] (24.952 ms) : 0, 24952
section iast
crashtracking [baseline] (1.454 ms) : 0, 1454
crashtracking [candidate] (1.457 ms) : 0, 1457
BytebuddyAgent [baseline] (815.817 ms) : 0, 815817
BytebuddyAgent [candidate] (816.012 ms) : 0, 816012
GlobalTracer [baseline] (231.698 ms) : 0, 231698
GlobalTracer [candidate] (231.268 ms) : 0, 231268
AppSec [baseline] (35.286 ms) : 0, 35286
AppSec [candidate] (35.16 ms) : 0, 35160
Debugger [baseline] (6.163 ms) : 0, 6163
Debugger [candidate] (6.1 ms) : 0, 6100
Remote Config [baseline] (606.766 µs) : 0, 607
Remote Config [candidate] (597.17 µs) : 0, 597
Telemetry [baseline] (8.73 ms) : 0, 8730
Telemetry [candidate] (8.659 ms) : 0, 8659
Flare Poller [baseline] (4.276 ms) : 0, 4276
Flare Poller [candidate] (4.259 ms) : 0, 4259
IAST [baseline] (26.941 ms) : 0, 26941
IAST [candidate] (26.641 ms) : 0, 26641
section profiling
crashtracking [baseline] (1.487 ms) : 0, 1487
crashtracking [candidate] (1.462 ms) : 0, 1462
BytebuddyAgent [baseline] (720.326 ms) : 0, 720326
BytebuddyAgent [candidate] (718.611 ms) : 0, 718611
GlobalTracer [baseline] (218.833 ms) : 0, 218833
GlobalTracer [candidate] (218.114 ms) : 0, 218114
AppSec [baseline] (32.221 ms) : 0, 32221
AppSec [candidate] (32.246 ms) : 0, 32246
Debugger [baseline] (7.451 ms) : 0, 7451
Debugger [candidate] (6.642 ms) : 0, 6642
Remote Config [baseline] (714.073 µs) : 0, 714
Remote Config [candidate] (681.759 µs) : 0, 682
Telemetry [baseline] (14.554 ms) : 0, 14554
Telemetry [candidate] (15.743 ms) : 0, 15743
Flare Poller [baseline] (4.922 ms) : 0, 4922
Flare Poller [candidate] (4.163 ms) : 0, 4163
ProfilingAgent [baseline] (109.741 ms) : 0, 109741
ProfilingAgent [candidate] (109.622 ms) : 0, 109622
Profiling [baseline] (110.361 ms) : 0, 110361
Profiling [candidate] (110.287 ms) : 0, 110287

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-api10-sampling-config
git_commit_date	1760967512	1761033164
git_commit_sha	`fb31324`	`4cc6b68`
release_version	1.55.0-SNAPSHOT~fb3132475b	1.55.0-SNAPSHOT~4cc6b680f6

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1761034633	1761034633
ci_job_id	1188366884	1188366884
ci_pipeline_id	79812521	79812521
cpu_model	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8175M CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-l2ppvwma 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-l2ppvwma 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 1 performance improvements and 3 performance regressions! Performance is the same for 8 metrics, 12 unstable metrics.

scenario	Δ mean http_req_duration	Δ mean throughput	candidate mean http_req_duration	candidate mean throughput	baseline mean http_req_duration	baseline mean throughput
scenario:load:insecure-bank:tracing:high_load	worse [+300.451µs; +587.284µs] or [+3.555%; +6.950%]	unstable [-90.464op/s; +36.651op/s] or [-16.500%; +6.685%]	8.895ms	521.344op/s	8.451ms	548.250op/s
scenario:load:insecure-bank:profiling:high_load	worse [+486.497µs; +824.171µs] or [+5.125%; +8.683%]	unstable [-90.600op/s; +27.787op/s] or [-18.520%; +5.680%]	10.147ms	457.781op/s	9.492ms	489.188op/s
scenario:load:petclinic:no_agent:high_load	worse [+1.867ms; +2.527ms] or [+5.124%; +6.935%]	unstable [-16.297op/s; +1.797op/s] or [-12.703%; +1.401%]	38.634ms	121.037op/s	36.437ms	128.287op/s
scenario:load:petclinic:profiling:high_load	better [-2.554ms; -1.494ms] or [-4.924%; -2.879%]	unstable [-3.350op/s; +10.650op/s] or [-3.711%; +11.800%]	49.847ms	93.900op/s	51.871ms	90.250op/s

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~4cc6b680f6, baseline=1.55.0-SNAPSHOT~fb3132475b
    dateFormat X
    axisFormat %s
section baseline
no_agent (36.437 ms) : 36142, 36732
.   : milestone, 36437,
appsec (48.456 ms) : 48034, 48878
.   : milestone, 48456,
code_origins (44.2 ms) : 43821, 44578
.   : milestone, 44200,
iast (46.61 ms) : 46185, 47034
.   : milestone, 46610,
profiling (51.871 ms) : 51362, 52380
.   : milestone, 51871,
tracing (44.81 ms) : 44424, 45196
.   : milestone, 44810,
section candidate
no_agent (38.634 ms) : 38316, 38952
.   : milestone, 38634,
appsec (49.644 ms) : 49210, 50078
.   : milestone, 49644,
code_origins (43.973 ms) : 43584, 44362
.   : milestone, 43973,
iast (47.419 ms) : 46994, 47844
.   : milestone, 47419,
profiling (49.847 ms) : 49371, 50323
.   : milestone, 49847,
tracing (44.877 ms) : 44494, 45261
.   : milestone, 44877,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	36.437 ms [36.142 ms, 36.732 ms]	-
appsec	48.456 ms [48.034 ms, 48.878 ms]	12.019 ms (33.0%)
code_origins	44.2 ms [43.821 ms, 44.578 ms]	7.763 ms (21.3%)
iast	46.61 ms [46.185 ms, 47.034 ms]	10.173 ms (27.9%)
profiling	51.871 ms [51.362 ms, 52.38 ms]	15.434 ms (42.4%)
tracing	44.81 ms [44.424 ms, 45.196 ms]	8.373 ms (23.0%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	38.634 ms [38.316 ms, 38.952 ms]	-
appsec	49.644 ms [49.21 ms, 50.078 ms]	11.01 ms (28.5%)
code_origins	43.973 ms [43.584 ms, 44.362 ms]	5.339 ms (13.8%)
iast	47.419 ms [46.994 ms, 47.844 ms]	8.785 ms (22.7%)
profiling	49.847 ms [49.371 ms, 50.323 ms]	11.213 ms (29.0%)
tracing	44.877 ms [44.494 ms, 45.261 ms]	6.243 ms (16.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.55.0-SNAPSHOT~4cc6b680f6, baseline=1.55.0-SNAPSHOT~fb3132475b
    dateFormat X
    axisFormat %s
section baseline
no_agent (4.629 ms) : 4573, 4686
.   : milestone, 4629,
iast (10.255 ms) : 10083, 10428
.   : milestone, 10255,
iast_FULL (14.805 ms) : 14508, 15101
.   : milestone, 14805,
iast_GLOBAL (11.084 ms) : 10885, 11284
.   : milestone, 11084,
profiling (9.492 ms) : 9334, 9650
.   : milestone, 9492,
tracing (8.451 ms) : 8318, 8583
.   : milestone, 8451,
section candidate
no_agent (4.584 ms) : 4530, 4638
.   : milestone, 4584,
iast (10.214 ms) : 10043, 10385
.   : milestone, 10214,
iast_FULL (14.817 ms) : 14520, 15115
.   : milestone, 14817,
iast_GLOBAL (11.502 ms) : 11288, 11715
.   : milestone, 11502,
profiling (10.147 ms) : 9992, 10303
.   : milestone, 10147,
tracing (8.895 ms) : 8760, 9029
.   : milestone, 8895,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.629 ms [4.573 ms, 4.686 ms]	-
iast	10.255 ms [10.083 ms, 10.428 ms]	5.626 ms (121.5%)
iast_FULL	14.805 ms [14.508 ms, 15.101 ms]	10.175 ms (219.8%)
iast_GLOBAL	11.084 ms [10.885 ms, 11.284 ms]	6.455 ms (139.4%)
profiling	9.492 ms [9.334 ms, 9.65 ms]	4.862 ms (105.0%)
tracing	8.451 ms [8.318 ms, 8.583 ms]	3.821 ms (82.5%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	4.584 ms [4.53 ms, 4.638 ms]	-
iast	10.214 ms [10.043 ms, 10.385 ms]	5.63 ms (122.8%)
iast_FULL	14.817 ms [14.52 ms, 15.115 ms]	10.234 ms (223.3%)
iast_GLOBAL	11.502 ms [11.288 ms, 11.715 ms]	6.918 ms (150.9%)
profiling	10.147 ms [9.992 ms, 10.303 ms]	5.563 ms (121.4%)
tracing	8.895 ms [8.76 ms, 9.029 ms]	4.311 ms (94.0%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	malvarez/fix-api10-sampling-config
git_commit_date	1760967512	1761033164
git_commit_sha	`fb31324`	`4cc6b68`
release_version	1.55.0-SNAPSHOT~fb3132475b	1.55.0-SNAPSHOT~4cc6b680f6

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1761035246	1761035246
ci_job_id	1188366885	1188366885
ci_pipeline_id	79812521	79812521
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zfyrx7zua-project-304-concurrent-0-lipwcwnu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zfyrx7zua-project-304-concurrent-0-lipwcwnu 6.8.0-1031-aws #33~22.04.1-Ubuntu SMP Thu Jun 26 14:22:30 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~4cc6b680f6, baseline=1.55.0-SNAPSHOT~fb3132475b
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.548 s) : 15548000, 15548000
.   : milestone, 15548000,
appsec (14.734 s) : 14734000, 14734000
.   : milestone, 14734000,
iast (18.739 s) : 18739000, 18739000
.   : milestone, 18739000,
iast_GLOBAL (18.073 s) : 18073000, 18073000
.   : milestone, 18073000,
profiling (15.29 s) : 15290000, 15290000
.   : milestone, 15290000,
tracing (15.049 s) : 15049000, 15049000
.   : milestone, 15049000,
section candidate
no_agent (15.378 s) : 15378000, 15378000
.   : milestone, 15378000,
appsec (14.676 s) : 14676000, 14676000
.   : milestone, 14676000,
iast (18.718 s) : 18718000, 18718000
.   : milestone, 18718000,
iast_GLOBAL (18.215 s) : 18215000, 18215000
.   : milestone, 18215000,
profiling (15.154 s) : 15154000, 15154000
.   : milestone, 15154000,
tracing (14.91 s) : 14910000, 14910000
.   : milestone, 14910000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.548 s [15.548 s, 15.548 s]	-
appsec	14.734 s [14.734 s, 14.734 s]	-814.0 ms (-5.2%)
iast	18.739 s [18.739 s, 18.739 s]	3.191 s (20.5%)
iast_GLOBAL	18.073 s [18.073 s, 18.073 s]	2.525 s (16.2%)
profiling	15.29 s [15.29 s, 15.29 s]	-258.0 ms (-1.7%)
tracing	15.049 s [15.049 s, 15.049 s]	-499.0 ms (-3.2%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.378 s [15.378 s, 15.378 s]	-
appsec	14.676 s [14.676 s, 14.676 s]	-702.0 ms (-4.6%)
iast	18.718 s [18.718 s, 18.718 s]	3.34 s (21.7%)
iast_GLOBAL	18.215 s [18.215 s, 18.215 s]	2.837 s (18.4%)
profiling	15.154 s [15.154 s, 15.154 s]	-224.0 ms (-1.5%)
tracing	14.91 s [14.91 s, 14.91 s]	-468.0 ms (-3.0%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.55.0-SNAPSHOT~4cc6b680f6, baseline=1.55.0-SNAPSHOT~fb3132475b
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.473 ms) : 1462, 1485
.   : milestone, 1473,
appsec (3.778 ms) : 3554, 4001
.   : milestone, 3778,
iast (2.226 ms) : 2161, 2291
.   : milestone, 2226,
iast_GLOBAL (2.256 ms) : 2191, 2321
.   : milestone, 2256,
profiling (2.062 ms) : 2009, 2114
.   : milestone, 2062,
tracing (2.035 ms) : 1984, 2085
.   : milestone, 2035,
section candidate
no_agent (1.483 ms) : 1471, 1495
.   : milestone, 1483,
appsec (3.81 ms) : 3586, 4034
.   : milestone, 3810,
iast (2.232 ms) : 2166, 2297
.   : milestone, 2232,
iast_GLOBAL (2.267 ms) : 2202, 2332
.   : milestone, 2267,
profiling (2.07 ms) : 2017, 2122
.   : milestone, 2070,
tracing (2.032 ms) : 1982, 2083
.   : milestone, 2032,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.462 ms, 1.485 ms]	-
appsec	3.778 ms [3.554 ms, 4.001 ms]	2.304 ms (156.4%)
iast	2.226 ms [2.161 ms, 2.291 ms]	752.651 µs (51.1%)
iast_GLOBAL	2.256 ms [2.191 ms, 2.321 ms]	782.239 µs (53.1%)
profiling	2.062 ms [2.009 ms, 2.114 ms]	588.169 µs (39.9%)
tracing	2.035 ms [1.984 ms, 2.085 ms]	561.389 µs (38.1%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.483 ms [1.471 ms, 1.495 ms]	-
appsec	3.81 ms [3.586 ms, 4.034 ms]	2.327 ms (156.9%)
iast	2.232 ms [2.166 ms, 2.297 ms]	748.752 µs (50.5%)
iast_GLOBAL	2.267 ms [2.202 ms, 2.332 ms]	784.105 µs (52.9%)
profiling	2.07 ms [2.017 ms, 2.122 ms]	586.735 µs (39.6%)
tracing	2.032 ms [1.982 ms, 2.083 ms]	549.334 µs (37.0%)

manuel-alvarez-alvarez · 2025-10-17T13:41:03Z

Do we know if any user is actually using the old env variable? I guess not, since it was released in the last version and probably isn’t in the public docs. Might be worth keeping both variables for now, just in case? I assume the answer is no, but just wanted to flag it in case you hadn’t considered it 🙂

Yeah, I added an alias to keep both for a while, thanks!

manuel-alvarez-alvarez requested review from a team as code owners October 17, 2025 10:22

manuel-alvarez-alvarez added type: bug Bug report and fix comp: asm waf Application Security Management (WAF) labels Oct 17, 2025

manuel-alvarez-alvarez requested review from jandro996, sezen-datadog and smola October 17, 2025 10:22

jandro996 reviewed Oct 17, 2025

View reviewed changes

Base automatically changed from malvarez/waf-fix-ssrf-blocking-exception to master October 17, 2025 13:16

manuel-alvarez-alvarez requested a review from a team as a code owner October 17, 2025 13:16

manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch 2 times, most recently from 6acbb27 to 4a5648d Compare October 17, 2025 13:36

manuel-alvarez-alvarez requested a review from jandro996 October 17, 2025 13:41

manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch from 4a5648d to ec39cb6 Compare October 20, 2025 08:34

manuel-alvarez-alvarez added 2 commits October 21, 2025 09:52

Rename request body sample rate config variable

0fc6dbc

Maintain old variable for a bit

4cc6b68

manuel-alvarez-alvarez force-pushed the malvarez/fix-api10-sampling-config branch from ec39cb6 to 4cc6b68 Compare October 21, 2025 07:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rename request body sample rate config variable #9791

Rename request body sample rate config variable #9791

manuel-alvarez-alvarez commented Oct 17, 2025 •

edited

Loading

Uh oh!

jandro996 left a comment

Uh oh!

datadog-official bot commented Oct 17, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

Uh oh!

pr-commenter bot commented Oct 17, 2025 •

edited

Loading

Uh oh!

manuel-alvarez-alvarez commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Rename request body sample rate config variable #9791

Are you sure you want to change the base?

Rename request body sample rate config variable #9791

Conversation

manuel-alvarez-alvarez commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

jandro996 left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-official bot commented Oct 17, 2025 • edited by datadog-datadog-prod-us1 bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pr-commenter bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

manuel-alvarez-alvarez commented Oct 17, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

manuel-alvarez-alvarez commented Oct 17, 2025 •

edited

Loading

datadog-official bot commented Oct 17, 2025 •

edited by datadog-datadog-prod-us1 bot

Loading

pr-commenter bot commented Oct 17, 2025 •

edited

Loading