Skip to content

Install missing lowdown and libsodium dependencies in Dockerfiles #8644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Install missing lowdown and libsodium dependencies in Dockerfiles #8644

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3835ae
tests: check openssl version compatibility for fuzz tests
ShahanaFarooqui Oct 29, 2025
d02fb3b
docker: install lowdown and libsodium-dev for reproducible builds
ShahanaFarooqui Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,12 @@ include cln-grpc/Makefile
endif
include plugins/Makefile
include tests/plugins/Makefile

# Only include fuzz tests if OpenSSL >= 3.0, will be disabled on ubuntu focal
OPENSSL_VERSION := $(shell openssl version | sed -n 's/OpenSSL \([0-9]\+\)\..*/\1/p')
ifneq ($(shell test $(OPENSSL_VERSION) -ge 3 && echo yes),)
include tests/fuzz/Makefile
endif

ifneq ($V,1)
MSGGEN_ARGS := -s
Expand Down
12 changes: 11 additions & 1 deletion contrib/docker/Dockerfile.builder.fedora
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,17 @@ RUN dnf update -y && \
jq \
xz \
zlib-devel \
cargo && \
cargo \
libsodium-devel && \
wget https://github.com/kristapsdz/lowdown/archive/refs/tags/VERSION_1_0_2.tar.gz && \
tar -xzf VERSION_1_0_2.tar.gz && \
cd lowdown-VERSION_1_0_2 && \
./configure && \
make && \
make install && \
ldconfig && \
cd /tmp && \
rm -rf VERSION_1_0_2.tar.gz lowdown-VERSION_1_0_2 && \
dnf clean all

RUN wget https://storage.googleapis.com/c-lightning-tests/bitcoind/bitcoin-${BITCOIN_VERSION}-x86_64-linux-gnu.tar.gz \
Expand Down
42 changes: 26 additions & 16 deletions contrib/reprobuild/Dockerfile.focal
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,22 +11,32 @@ RUN sed -i '/updates/d' /etc/apt/sources.list && \
sed -i '/security/d' /etc/apt/sources.list

RUN apt-get update \
&& apt-get install -y --no-install-recommends \
autoconf \
build-essential \
ca-certificates \
file \
gettext \
git \
libpq-dev \
libsodium23 \
libtool \
m4 \
sudo \
unzip \
wget \
git \
zip
&& apt-get install -y --no-install-recommends \
autoconf \
build-essential \
ca-certificates \
file \
gettext \
git \
libpq-dev \
libsodium23 \
libsodium-dev \
libtool \
m4 \
sudo \
unzip \
wget \
zip \
&& cd /tmp \
&& wget https://github.com/kristapsdz/lowdown/archive/refs/tags/VERSION_1_0_2.tar.gz \
&& tar -xzf VERSION_1_0_2.tar.gz \
&& cd lowdown-VERSION_1_0_2 \
&& ./configure \
&& make \
&& make install \
&& ldconfig \
&& cd / \
&& rm -rf /tmp/VERSION_1_0_2.tar.gz /tmp/lowdown-VERSION_1_0_2

# Ensure correct ownership
RUN chown root:root /etc/sudoers
Expand Down
47 changes: 29 additions & 18 deletions contrib/reprobuild/Dockerfile.jammy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,35 @@ ENV PROTOC_VERSION=29.4
RUN sed -i '/updates/d' /etc/apt/sources.list && \
sed -i '/security/d' /etc/apt/sources.list

RUN apt-get update \
&& apt-get install -y --no-install-recommends \
autoconf \
build-essential \
ca-certificates \
file \
gettext \
git \
libsqlite3-dev \
libpq-dev \
libsodium23 \
libtool \
m4 \
sudo \
unzip \
wget \
jq \
zip
RUN apt-get update && \
apt-get install -y --no-install-recommends \
autoconf \
build-essential \
ca-certificates \
file \
gettext \
git \
libsqlite3-dev \
libpq-dev \
libsodium23 \
libsodium-dev \
libtool \
m4 \
sudo \
unzip \
wget \
jq \
zip \
&& cd /tmp \
&& wget https://github.com/kristapsdz/lowdown/archive/refs/tags/VERSION_1_0_2.tar.gz \
&& tar -xzf VERSION_1_0_2.tar.gz \
&& cd lowdown-VERSION_1_0_2 \
&& ./configure \
&& make \
&& make install \
&& ldconfig \
&& cd / \
&& rm -rf /tmp/VERSION_1_0_2.tar.gz /tmp/lowdown-VERSION_1_0_2

# Ensure correct ownership
RUN chown root:root /etc/sudoers
Expand Down
2 changes: 2 additions & 0 deletions contrib/reprobuild/Dockerfile.noble
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ RUN apt-get update \
libsqlite3-dev \
libpq-dev \
libsodium23 \
libsodium-dev \
lowdown \
libtool \
m4 \
sudo \
Expand Down
1 change: 1 addition & 0 deletions tools/repro-build.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ adae5a301c7899c1bce8ae26b5423716a47e516df25c09d6d536607bc34853bc /var/cache/apt
d8b8653388e676a3ae2fcf565c2b1a42a01a1104062317f641e8d24f0eaff9c3 /var/cache/apt/archives/libpq-dev_14.2-1ubuntu1_amd64.deb
542dcee1409c74d03ecdd4ca4a0cfd467e5d2804d9985b58e39d3c5889a409e3 /var/cache/apt/archives/libpq5_14.2-1ubuntu1_amd64.deb
885ee09c37d0e37ef6042e8cb4a22ccbab92101f21ab0c8f51ae961e4484407c /var/cache/apt/archives/libsodium23_1.0.18-1build2_amd64.deb
09584c8ab2f840bf3db4a5763f6e4b450688aa8879acd4c8f4c1942375b9ca57 /var/cache/apt/archives/libsodium-dev_1.0.18-1build2_amd64.deb
000a1d5c0df0373c75fadbfea604afb6b1325bf866a3ce637ae0138abe6d556d /var/cache/apt/archives/libsqlite3-0_3.37.2-2_amd64.deb
1b2a93020593c9e94a25f750ce442da5a6e8ff48a20f52cec92dfc3fa35336d8 /var/cache/apt/archives/linux-libc-dev_5.15.0-25.25_amd64.deb
572a544d2c18bf49d25c465720c570cd8e6e38731386ac9c0a7f29bed2486f3e /var/cache/apt/archives/m4_1.4.18-5ubuntu2_amd64.deb
Expand Down
Loading