Always use default ports for *sending* NetBIOS messages #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way I understand it, the ability to use a custom port is mainly relevant for listening (because you can't bind a socket to a port < 1023 without root on unixoid systems), and the documentation explicitly points out the scenario of configuring a non-privileged port and then use firewall rules to forward the network traffic to the unprivileged port.
In that case, it wouldn't make sense to use the same alternative ports as the destination port when sending out various broadcast messages, however this is exactly what currently happens.
We already hardcode e.g. the name server port when sending out a few messages (e.g. here), so I just propose completing that status and hardcode the remaining messages relevant for the name server and the host announcer, too.