refactor: use release-please markers for version #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on.spec Use x-release-please markers directly in the code to maintain a pseudo-hardcoded version number, rather than reading from Application.spec at runtime. This approach: - Makes the implementation consistent across Flagsmith SDKs - Relies solely on release-please for version management - Keeps version visible in source code for easier debugging - Simplifies the user_agent/0 function implementation The version is now defined directly in lib/flagsmith_client.ex between x-release-please markers, and release-please will automatically update it during releases. Also removed the redundant user_agent/0 unit test since the function now simply returns a hardcoded string with no conditional logic. The HTTP integration test sufficiently validates the User-Agent header behavior. Co-authored-by: Claude <claude@anthropic.com>
Open
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This work was authored by Claude (AI assistant) and supervised by @emyller.
This PR refactors the User-Agent version implementation to use release-please markers directly in the code, rather than reading from
Application.specat runtime.Contributes to #49