feat: removed-feature-key-and-segment-key-from-schema #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zaimwa9
commented
Oct 23, 2025
.gitmodules
Outdated
| path = tests/engine/engine-tests/engine-test-data | ||
| url = git@github.com:Flagsmith/engine-test-data.git | ||
| branch = v2.5.0 | ||
| branch = feat/remove-feature-key-fields |
There was a problem hiding this comment.
TODO: remove once merged
Zaimwa9
commented
Oct 23, 2025
package.json
Outdated
Comment on lines
61
to
62
| "generate-evaluation-result-types": "curl -o evaluation-result.json https://raw.githubusercontent.com/Flagsmith/flagsmith/chore%2Fevaluation-context0key/sdk/evaluation-result.json && npx json2ts -i evaluation-result.json -o flagsmith-engine/evaluation/evaluationResult/evaluationResult.types.ts && rm evaluation-result.json", | ||
| "generate-evaluation-context-types": "curl -o evaluation-context.json https://raw.githubusercontent.com/Flagsmith/flagsmith/chore%2Fevaluation-context0key/sdk/evaluation-context.json && npx json2ts -i evaluation-context.json -o flagsmith-engine/evaluation/evaluationContext/evaluationContext.types.ts && rm evaluation-context.json", |
There was a problem hiding this comment.
TODO: revert once merged
gagantrivedi
requested changes
Oct 24, 2025
sdk/models.ts
Outdated
| if (!flagsmithId) { | ||
| const flagsmith_id = flag.metadata?.flagsmith_id; | ||
| if (!flagsmith_id) { | ||
| continue; |
There was a problem hiding this comment.
Should we skip returning the feature if it doesn’t have an ID?
There was a problem hiding this comment.
yes that's what we are doing, as the continue skips adding it to the map
There was a problem hiding this comment.
No, I am saying, why should we do that? The metadata/ID being none is likely a bug?
There was a problem hiding this comment.
Python SDK is throwing an error in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FeatureContext.feature_keyand useFeatureContext.namefor override matchingSegmentResult.keyFeatureMetadata.flagsmithIdtoFeatureMetadata.flagsmith_idmetadata.flagsmith_idevaluation/models.ts