Performance Improvement | Documentation Update #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- I changed transactionChargeType as a String to an enum. It will be easier for someone who is not familiar with the type of transaction charge type, to be able to use it without confusion. - I also noticed that the previous Contribution guidelines link is preventing everyone from accessing it. So I changed it to the Contribution guidelines available.
- I changed the way we input the payment option. As it is inputted into a list, it converts to a String as before. It is just easier for devs. - I added assertions to cross-check that both paymentOptions and paymentOptionsList are not non-null.
Upgrade the Example Compile SDK Version to 33 and changed the GradleException to FileNotFoundException as it is not used again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made few changes that makes development relatively easy. The following: