Skip to content

Conversation

@bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Feb 8, 2024

This PR adds pygeosx unit tests to Github Actions, specfically images with Ubuntu 22 to satisfy the python version requirement (>=3.10) .

Related to GEOS-DEV/thirdPartyLibs#259

@bmhan12 bmhan12 self-assigned this Feb 8, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from c77049b to a6d41a6 Compare February 15, 2024 16:27
@codecov
Copy link

codecov bot commented Feb 16, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.91%. Comparing base (3a78f14) to head (7141a29).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2981   +/-   ##
========================================
  Coverage    58.91%   58.91%           
========================================
  Files         1320     1320           
  Lines       114764   114764           
========================================
+ Hits         67609    67611    +2     
+ Misses       47155    47153    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch 2 times, most recently from 5abaa1a to 33e7712 Compare February 28, 2024 21:00
@bmhan12 bmhan12 changed the title [WIP] pygeosx testing pygeosx testing Feb 29, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from 33e7712 to c72ba06 Compare March 5, 2024 23:23
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch 2 times, most recently from eb9eebc to ae87421 Compare March 14, 2024 15:31
@untereiner
Copy link
Contributor

Should pygeosx be renamed pygeos ? Would it be the good moment to do it ?

@TotoGaz
Copy link
Contributor

TotoGaz commented Mar 14, 2024

Should pygeosx be renamed pygeos ?

Yes it should #2331

Would it be the good moment to do it ?

I guess that would be MAKUTU to steer the change @sframba

Copy link
Contributor

@cssherman cssherman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from f892168 to fb07769 Compare April 22, 2024 16:13
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from fb07769 to 50648ab Compare May 22, 2025 14:32
@bmhan12 bmhan12 changed the title pygeosx testing [WIP] pygeosx testing May 22, 2025
@bmhan12 bmhan12 added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI labels May 22, 2025
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from 50648ab to 411c1de Compare May 22, 2025 16:11
@bmhan12 bmhan12 added the ci: run code coverage enables running of the code coverage CI jobs label May 22, 2025
@bmhan12 bmhan12 changed the title [WIP] pygeosx testing pygeosx testing May 29, 2025
@bmhan12 bmhan12 changed the title pygeosx testing ci: pygeosx testing May 29, 2025
@bmhan12
Copy link
Contributor Author

bmhan12 commented Jun 5, 2025

This PR has been updated (post-spack changes), and is ready for review.

@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from 8df337f to a333469 Compare June 12, 2025 21:05
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from a333469 to 35ceb9c Compare July 10, 2025 18:44
@paveltomin
Copy link
Collaborator

@rrsettgast review?

@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from 35ceb9c to 2903ba2 Compare August 21, 2025 20:41
@bmhan12 bmhan12 force-pushed the feature/han12/pygeosx_docker branch from 2903ba2 to 392a4a6 Compare August 28, 2025 22:13
@bmhan12 bmhan12 requested a review from paveltomin as a code owner September 11, 2025 15:03
@bmhan12 bmhan12 added the flag: requires updated TPL(s) Needs a specific TPL PR label Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: ready for review flag: requires updated TPL(s) Needs a specific TPL PR type: CI Concerns github workflows or generic CI type: pygeosx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants