Skip to content

Conversation

@bmhan12
Copy link
Contributor

@bmhan12 bmhan12 commented Mar 14, 2024

This PR attempts to run Github Actions using Docker images with dependencies built with uberenv, spack.

Related to GEOS-DEV/thirdPartyLibs#261
Relates to GEOS-DEV/LvArray#318

@bmhan12 bmhan12 self-assigned this Mar 14, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from e88ad2b to ed09300 Compare March 28, 2024 21:02
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from 606df70 to eb9b77f Compare April 4, 2024 21:34
@bmhan12 bmhan12 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Apr 18, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 3 times, most recently from 9aa2678 to ada149c Compare April 18, 2024 18:42
@bmhan12 bmhan12 removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Apr 18, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 3 times, most recently from d1a5ed4 to b9f7735 Compare April 18, 2024 21:58
@bmhan12 bmhan12 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Apr 18, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from b9f7735 to f673591 Compare April 25, 2024 21:37
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from f673591 to a090c3b Compare May 9, 2024 16:10
@bmhan12 bmhan12 removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 16, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 2 times, most recently from 3188c78 to ad53f07 Compare May 23, 2024 16:29
@bmhan12 bmhan12 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 30, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch 2 times, most recently from 45f9942 to 76adca4 Compare May 30, 2024 18:21
@bmhan12 bmhan12 removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label May 30, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from 76adca4 to 52cdc7f Compare June 6, 2024 17:06
@bmhan12 bmhan12 added the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jun 6, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from 52cdc7f to ce09009 Compare June 6, 2024 18:37
@bmhan12 bmhan12 removed the ci: run CUDA builds Allows to triggers (costly) CUDA jobs label Jun 27, 2024
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from ce09009 to e8b3a32 Compare July 18, 2024 23:34
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from a4a3e99 to be54b83 Compare January 17, 2025 00:23
Comment on lines +252 to +257
-DENABLE_HYPRE=${ENABLE_HYPRE} \
-DENABLE_HYPRE_DEVICE=${ENABLE_HYPRE_DEVICE} \
-DENABLE_TRILINOS=${ENABLE_TRILINOS} \
-DGEOS_LA_INTERFACE:PATH=${GEOS_LA_INTERFACE} \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the need to specify both ENABLE_TRILINOS and GEOS_LA_INTERFACE?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the need to specify both ENABLE_TRILINOS and GEOS_LA_INTERFACE?

The current way the linear algebra packages are configured in the CI jobs is by setting the ENABLE_HYPRE and ENABLE_TRILINOS variables as environment variables:

# The linear algebra environment variables (ENABLE_HYPRE, ENABLE_HYPRE_DEVICE & ENABLE_TRILINOS)
# could be passed as scripts parameters as well, but a specific care must be taken to be sure
# there's no conflict with the host-config files.
ENABLE_HYPRE=${{ inputs.ENABLE_HYPRE }}
ENABLE_HYPRE_DEVICE=${{ inputs.ENABLE_HYPRE_DEVICE }}
ENABLE_TRILINOS=${{ inputs.ENABLE_TRILINOS }}
docker_args+=(-e ENABLE_HYPRE=${ENABLE_HYPRE:-OFF})
docker_args+=(-e ENABLE_HYPRE_DEVICE=${ENABLE_HYPRE_DEVICE:-CPU})
docker_args+=(-e ENABLE_TRILINOS=${ENABLE_TRILINOS:-ON})

Then reading those environment variables into CMake and choosing a GEOS_LA_INTERFACE from there:

# If not defined as argument, take from the environment...
if(NOT DEFINED ENABLE_HYPRE)
set(ENABLE_HYPRE "$ENV{ENABLE_HYPRE}" CACHE BOOL "" FORCE)
endif()
# ... and then check the value.
if(ENABLE_HYPRE)
set(GEOS_LA_INTERFACE "Hypre" CACHE STRING "" FORCE)
else()
set(ENABLE_HYPRE OFF CACHE BOOL "" FORCE)
endif()
# Same pattern
if(NOT DEFINED ENABLE_TRILINOS)
set(ENABLE_TRILINOS "$ENV{ENABLE_TRILINOS}" CACHE BOOL "" FORCE)
endif()
if(ENABLE_TRILINOS)
set(GEOS_LA_INTERFACE "Trilinos" CACHE STRING "" FORCE)
else()
set(ENABLE_TRILINOS FALSE CACHE BOOL "" FORCE)
endif()
if( (ENABLE_HYPRE AND ENABLE_TRILINOS) OR (NOT ENABLE_TRILINOS AND NOT ENABLE_HYPRE))
MESSAGE(SEND_ERROR "Exactly one of ENABLE_HYPRE and ENABLE_TRILINOS must be defined.")
MESSAGE(SEND_ERROR "ENABLE_HYPRE = ${ENABLE_HYPRE}.")
MESSAGE(SEND_ERROR "ENABLE_TRILINOS = ${ENABLE_TRILINOS}.")
endif()
MESSAGE(STATUS "GEOS_LA_INTERFACE = ${GEOS_LA_INTERFACE}")

Instead of reading in environment variables from environment.cmake, the spack Docker containers each generate a host-config (spack-generated.cmake) to use instead, where the GEOS_LA_INTERFACE is by default set to Hypre. The snippet added here is for overriding the spack host-config defaults by defining those variables through CMake (passing them to config-build.py) instead of reading them through environment variables. This is done for CI jobs that have GEOS_LA_INTERFACE set to Trilinos.

@rrsettgast rrsettgast requested a review from Bubusch January 30, 2025 18:16
@bmhan12 bmhan12 force-pushed the feature/han12/docker_spack branch from be54b83 to 861477e Compare January 30, 2025 22:06
* `Manual compiler configuration <https://spack.readthedocs.io/en/latest/getting_started.html?highlight=compilers.yaml#manual-compiler-configuration>`_
* `External packages <https://spack.readthedocs.io/en/latest/packages_yaml.html#external-packages>`_

Building the dependencies can be as simple as running:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would remove this part about this generic command and start by saying that a spack-env file must be specified.

@rrsettgast rrsettgast merged commit 116560f into develop Feb 12, 2025
25 of 27 checks passed
@rrsettgast rrsettgast deleted the feature/han12/docker_spack branch February 12, 2025 07:58
MelReyCG added a commit that referenced this pull request Mar 11, 2025
commit 7b8a26a
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Fri Feb 21 11:31:15 2025 +0100

    set better alignment to linear solver table

commit 73b70d3
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Feb 20 14:56:08 2025 +0100

    again unused code

commit d373f0b
Merge: 6d06ac1 fb83361
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Feb 20 14:48:04 2025 +0100

    Merge remote-tracking branch 'origin/develop' into refactor/dudes/refactoring-logs-into-dynamic-tables

commit 6d06ac1
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Feb 20 14:46:15 2025 +0100

    unused code

commit c37c0e0
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Feb 20 14:31:26 2025 +0100

    xsddd

commit 0071a18
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Feb 20 14:31:06 2025 +0100

    alignment correction + load balancing table v2 + remove unused code

commit fa792c3
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Thu Feb 20 14:30:03 2025 +0100

    set mesh partionner smaller and removed some info if rank size = 1

commit fb83361
Author: Matteo Frigo <43966286+matteofrigo5@users.noreply.github.com>
Date:   Wed Feb 19 12:05:33 2025 -0800

    ci: Add Passing Crack to the integrated tests (#3551)

commit 0bef7f7
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Feb 19 16:54:22 2025 +0100

    fix alignment when subcolumn added

commit f330bae
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Wed Feb 19 15:38:16 2025 +0100

    v2 load balancing

commit d0488af
Author: Tom Byer <149726499+tjb-ltk@users.noreply.github.com>
Date:   Tue Feb 18 09:31:38 2025 -0800

    fix:  sync well constraint (#3541)

commit 8b90c29
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Tue Feb 18 17:30:19 2025 +0100

    load balancing tabl 1st version

commit 32dd263
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Tue Feb 18 17:29:49 2025 +0100

    fields table 1st version

commit b41f371
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Tue Feb 18 17:29:35 2025 +0100

    solubility table 1st version

commit 4c29851
Author: arng40 <arnaud.dudes@capgemini.com>
Date:   Tue Feb 18 17:29:06 2025 +0100

    some comment and ranming on table

commit abcd86b
Author: rasimHZ <43099968+rasimHZ@users.noreply.github.com>
Date:   Mon Feb 17 19:31:13 2025 -0600

    feat: Overall Composition (Z) Formulation (#3443)

commit dd5ba47
Author: Matteo Cusini <49037133+CusiniM@users.noreply.github.com>
Date:   Mon Feb 17 13:52:25 2025 -0800

    fix: segFault in ThermoPoromechanics EFEM case (#3552)

commit d32d40e
Author: Pavel Tomin <paveltomin@users.noreply.github.com>
Date:   Mon Feb 17 13:22:55 2025 -0600

    fix: multiphase contact bugfix, add test case to ats (#3547)

commit 78cd7c4
Author: Pavel Tomin <paveltomin@users.noreply.github.com>
Date:   Sat Feb 15 18:47:01 2025 -0600

    ci: fix 1d edfm case and add it to ats (#3546)

commit e5f4104
Author: Pavel Tomin <paveltomin@users.noreply.github.com>
Date:   Sat Feb 15 16:59:38 2025 -0600

    refactor: remove SolidMechanicsLagrangianSSLE and rename SolidMechanics_LagrangianFEM to SolidMechanicsLagrangianFEM (#3533)

    Co-authored-by: Randolph Settgast <settgast1@llnl.gov>

commit 27e0ca3
Author: Arnaud DUDES <155963334+arng40@users.noreply.github.com>
Date:   Sat Feb 15 21:45:53 2025 +0100

    feat: restore elementCount in SourceFluxStatistics log table (#3540)

commit ec81e8b
Author: Pavel Tomin <paveltomin@users.noreply.github.com>
Date:   Fri Feb 14 20:53:06 2025 -0600

    ci: remove code owners from .integrated_tests.yaml (#3503)

    * fix: remove code owners from .integrated_tests.yaml

commit 76070c6
Author: MelReyCG <122801580+MelReyCG@users.noreply.github.com>
Date:   Fri Feb 14 22:23:50 2025 +0100

    fix: SegFault when a MPI rank has no data of a sub-region (#3529)

commit bcf36f5
Author: Randolph Settgast <settgast1@llnl.gov>
Date:   Thu Feb 13 23:16:14 2025 -0800

    refactor: Remove all instances of array1d<string> (#2968)

    * replace some of the array1d<string> with string_array which is an alias for std::vector<string>

    * add consideration for packing of std::vector<T>

    * generalize vector packing/unpacking

    * add more packing functions for vector<string>

    * replace SortedArray<string> with set<string>

    * replace array1d<MPI_XXXX> with vector

    * update baselines

commit 6769693
Author: Randolph Settgast <settgast1@llnl.gov>
Date:   Thu Feb 13 00:44:34 2025 -0800

    ci: avoid creating files from inside docker container as root (#3542)

    * try running docker as nobody

    * repopulate schema with missing entries

    * rtd fixes

    * update TPL_TAG.

    * add spack generated hostconfigs

    * move ubuntu cuda build to streak2 and disable unit tests

commit 983f60d
Author: Pavel Tomin <paveltomin@users.noreply.github.com>
Date:   Wed Feb 12 15:17:42 2025 -0600

    ci: Fix unit tests for Sherlock CPU (#3544)

    * ci: Disable unit tests for Sherlock CPU

    * Use calculated critical volumes

    Co-authored-by: Pavel Tomin <ptls@PW0BMYGN>
    Co-authored-by: dkachuma <dickkachuma@googlemail.com>

commit 116560f
Author: Brian Han <han12@llnl.gov>
Date:   Tue Feb 11 23:57:59 2025 -0800

    ci: Spack docker containers (#3039)

    * Update tag, add PySolver snippet, adjust lai setting

    * Generalize umpire dependency

    * Add LAI interface toggle

    * Remove uberenv submodule and uberenv/spack configuration files from GEOS repository

    * Specify path to ATS python3 executable

    * Update docs

    * Update docs with info about LC script

    * Sherlock changes; adjust hypre/trilinos defaults, make lai setting explicit per job

    * disable sherlock unit tests
arng40 added a commit that referenced this pull request Mar 14, 2025
commit 838fa4c
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Mar 13 16:55:13 2025 +0100

    📝 forgot some notes of mine

commit e958e88
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Mar 13 16:30:55 2025 +0100

    ⚰️ disabled barrier on functions setOutputDirectory()

commit d19f739
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Mar 13 12:00:29 2025 +0100

    📝 docs

commit 0985c3c
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Mar 13 11:58:35 2025 +0100

    🎨 auto const

commit f9ded08
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Mar 12 14:48:34 2025 +0100

    ⚰️ dead code

commit 005dc4f
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Mar 12 14:27:34 2025 +0100

    ✅ merged with maxColumnWidth feature, unit tests now all pass

commit 1419202
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Mar 12 13:55:14 2025 +0100

    ✅ added linebreak in title in a test

commit 31eb057
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Mar 12 11:36:26 2025 +0100

    ✅ re-applied new testTable.variadicTest results (wrong merge choice)

commit 54a7d03
Merge: 17bde14 4f382df
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Mar 12 11:32:11 2025 +0100

    Merge remote-tracking branch 'origin/develop' into bugfix/rey/csv-export-fail

commit 17bde14
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Mar 11 16:58:20 2025 +0100

    ⚡️ precompute showed column count + maxDepth -> columnLayerCount

commit f1ebf01
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Mar 11 15:08:33 2025 +0100

    📝docs

commit f9814fb
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Mar 11 14:56:45 2025 +0100

    🎨 🐛 Used a more reliable "PreparedTableLayout" type to avoid buggy and / or complicated std::move()

commit 44befdd
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Mar 11 11:04:15 2025 +0100

    ⚰️ remove dead code

commit 22bda85
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Mar 10 17:12:24 2025 +0100

    🎨 🐛 fix table title containment + naming

commit cd9f51d
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Mar 10 16:44:47 2025 +0100

    ⚡️ CellLayout is now a view on the const data

commit 3a42551
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Mar 10 16:33:53 2025 +0100

    ⚡️ avoiding useless memory alloc/dealloc (benched 40% faster)

commit bb7c1ae
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Mar 11 17:26:43 2025 +0100

    🎨 enforced constness without "cheating" (creating non-const copy where not necessary)

commit 2111525
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Fri Mar 7 11:18:47 2025 +0100

    ✅ adapt test (whitespaces)

commit db1afa1
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Fri Mar 7 11:18:25 2025 +0100

    ✨ allow hidden cells

commit 75343a3
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Fri Mar 7 11:18:18 2025 +0100

    🎨 ⚡️ 🐛 in depth refactor to:
    1. resolve a bug with wide merged cells,
    2. add a compression pass to optimize table width,
    3. attempt to propose a clearer code,
    4. optimize formatting,
    5. improve constness practices.

commit 1af052e
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Fri Mar 7 09:53:44 2025 +0100

    🧪 Adding tests that should run (merged cells behaviour, optimization of space)

commit 9797a23
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Fri Mar 7 09:48:49 2025 +0100

    🎨 tableLayout refactor (naming, documentation + one constructor)

commit 002bfed
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Feb 25 11:03:43 2025 +0100

    ⚰️ removing no-op

commit da71ebe
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 24 15:23:45 2025 +0100

    🎨 🐛 few code style & keeping parent alignment properly

commit 6771a60
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 24 15:21:32 2025 +0100

    Squashed commit of the following:

    commit 7b8a26a
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Fri Feb 21 11:31:15 2025 +0100

        set better alignment to linear solver table

    commit 73b70d3
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Thu Feb 20 14:56:08 2025 +0100

        again unused code

    commit d373f0b
    Merge: 6d06ac1 fb83361
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Thu Feb 20 14:48:04 2025 +0100

        Merge remote-tracking branch 'origin/develop' into refactor/dudes/refactoring-logs-into-dynamic-tables

    commit 6d06ac1
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Thu Feb 20 14:46:15 2025 +0100

        unused code

    commit c37c0e0
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Thu Feb 20 14:31:26 2025 +0100

        xsddd

    commit 0071a18
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Thu Feb 20 14:31:06 2025 +0100

        alignment correction + load balancing table v2 + remove unused code

    commit fa792c3
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Thu Feb 20 14:30:03 2025 +0100

        set mesh partionner smaller and removed some info if rank size = 1

    commit fb83361
    Author: Matteo Frigo <43966286+matteofrigo5@users.noreply.github.com>
    Date:   Wed Feb 19 12:05:33 2025 -0800

        ci: Add Passing Crack to the integrated tests (#3551)

    commit 0bef7f7
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Wed Feb 19 16:54:22 2025 +0100

        fix alignment when subcolumn added

    commit f330bae
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Wed Feb 19 15:38:16 2025 +0100

        v2 load balancing

    commit d0488af
    Author: Tom Byer <149726499+tjb-ltk@users.noreply.github.com>
    Date:   Tue Feb 18 09:31:38 2025 -0800

        fix:  sync well constraint (#3541)

    commit 8b90c29
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Tue Feb 18 17:30:19 2025 +0100

        load balancing tabl 1st version

    commit 32dd263
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Tue Feb 18 17:29:49 2025 +0100

        fields table 1st version

    commit b41f371
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Tue Feb 18 17:29:35 2025 +0100

        solubility table 1st version

    commit 4c29851
    Author: arng40 <arnaud.dudes@capgemini.com>
    Date:   Tue Feb 18 17:29:06 2025 +0100

        some comment and ranming on table

    commit abcd86b
    Author: rasimHZ <43099968+rasimHZ@users.noreply.github.com>
    Date:   Mon Feb 17 19:31:13 2025 -0600

        feat: Overall Composition (Z) Formulation (#3443)

    commit dd5ba47
    Author: Matteo Cusini <49037133+CusiniM@users.noreply.github.com>
    Date:   Mon Feb 17 13:52:25 2025 -0800

        fix: segFault in ThermoPoromechanics EFEM case (#3552)

    commit d32d40e
    Author: Pavel Tomin <paveltomin@users.noreply.github.com>
    Date:   Mon Feb 17 13:22:55 2025 -0600

        fix: multiphase contact bugfix, add test case to ats (#3547)

    commit 78cd7c4
    Author: Pavel Tomin <paveltomin@users.noreply.github.com>
    Date:   Sat Feb 15 18:47:01 2025 -0600

        ci: fix 1d edfm case and add it to ats (#3546)

    commit e5f4104
    Author: Pavel Tomin <paveltomin@users.noreply.github.com>
    Date:   Sat Feb 15 16:59:38 2025 -0600

        refactor: remove SolidMechanicsLagrangianSSLE and rename SolidMechanics_LagrangianFEM to SolidMechanicsLagrangianFEM (#3533)

        Co-authored-by: Randolph Settgast <settgast1@llnl.gov>

    commit 27e0ca3
    Author: Arnaud DUDES <155963334+arng40@users.noreply.github.com>
    Date:   Sat Feb 15 21:45:53 2025 +0100

        feat: restore elementCount in SourceFluxStatistics log table (#3540)

    commit ec81e8b
    Author: Pavel Tomin <paveltomin@users.noreply.github.com>
    Date:   Fri Feb 14 20:53:06 2025 -0600

        ci: remove code owners from .integrated_tests.yaml (#3503)

        * fix: remove code owners from .integrated_tests.yaml

    commit 76070c6
    Author: MelReyCG <122801580+MelReyCG@users.noreply.github.com>
    Date:   Fri Feb 14 22:23:50 2025 +0100

        fix: SegFault when a MPI rank has no data of a sub-region (#3529)

    commit bcf36f5
    Author: Randolph Settgast <settgast1@llnl.gov>
    Date:   Thu Feb 13 23:16:14 2025 -0800

        refactor: Remove all instances of array1d<string> (#2968)

        * replace some of the array1d<string> with string_array which is an alias for std::vector<string>

        * add consideration for packing of std::vector<T>

        * generalize vector packing/unpacking

        * add more packing functions for vector<string>

        * replace SortedArray<string> with set<string>

        * replace array1d<MPI_XXXX> with vector

        * update baselines

    commit 6769693
    Author: Randolph Settgast <settgast1@llnl.gov>
    Date:   Thu Feb 13 00:44:34 2025 -0800

        ci: avoid creating files from inside docker container as root (#3542)

        * try running docker as nobody

        * repopulate schema with missing entries

        * rtd fixes

        * update TPL_TAG.

        * add spack generated hostconfigs

        * move ubuntu cuda build to streak2 and disable unit tests

    commit 983f60d
    Author: Pavel Tomin <paveltomin@users.noreply.github.com>
    Date:   Wed Feb 12 15:17:42 2025 -0600

        ci: Fix unit tests for Sherlock CPU (#3544)

        * ci: Disable unit tests for Sherlock CPU

        * Use calculated critical volumes

        Co-authored-by: Pavel Tomin <ptls@PW0BMYGN>
        Co-authored-by: dkachuma <dickkachuma@googlemail.com>

    commit 116560f
    Author: Brian Han <han12@llnl.gov>
    Date:   Tue Feb 11 23:57:59 2025 -0800

        ci: Spack docker containers (#3039)

        * Update tag, add PySolver snippet, adjust lai setting

        * Generalize umpire dependency

        * Add LAI interface toggle

        * Remove uberenv submodule and uberenv/spack configuration files from GEOS repository

        * Specify path to ATS python3 executable

        * Update docs

        * Update docs with info about LC script

        * Sherlock changes; adjust hypre/trilinos defaults, make lai setting explicit per job

        * disable sherlock unit tests

commit 8b7775e
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 24 15:19:04 2025 +0100

    🎨 clearer condition

commit 1ec61bf
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 24 14:47:52 2025 +0100

    🚧 call computeCellWidth() whenever needed

commit 90d2de6
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 24 10:49:18 2025 +0100

    🧪 adding longer titles to test the "too wide table" bug

commit b97c43c
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 24 10:23:28 2025 +0100

    🎨 uncrustify

commit ae6b458
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 24 10:23:18 2025 +0100

    💄 improved "too big table" warning visibility & separated table description

commit 9cf6975
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 24 09:40:13 2025 +0100

    ✨ adding a Column::addSubColumns signature to be compatible with Table2Ds

commit be3c5d7
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Fri Feb 21 17:40:26 2025 +0100

    💩 preparing return of N-D tables in log

commit e8b5d1b
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Fri Feb 21 16:50:12 2025 +0100

    🐛 🎨 table log output decision is now done consistently at one unique place

commit 37fd687
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 20 16:32:53 2025 +0100

    🐛 ultimate compil fix

commit b9b2a7d
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 20 15:59:17 2025 +0100

    💄  Uniformizing coordinates and units + better 1D layout

commit 14d6740
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 20 14:52:51 2025 +0100

    💄  better units description

commit 3a9f105
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 20 14:48:12 2025 +0100

    💄 keep full axis description in CSVs

commit fc97c88
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 20 14:33:58 2025 +0100

    🎨 uncrustify

commit ccaaa65
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 20 14:33:35 2025 +0100

    💄 fixing layout to be more user-friendly

commit 296e521
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 20 14:32:25 2025 +0100

    💡 comment on Unit enum for correctness

commit f5de5b9
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 20 14:26:27 2025 +0100

    ✨ Adding getVariableSymbol() to units to get a standard variable symbol

commit 62e22c2
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 17:11:19 2025 +0100

    💄 CSV tables should keep units as they have no title like in the log

commit fb37f8f
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 16:40:10 2025 +0100

    📦 our beloved schema

commit 9677772
Merge: cdb39bc f1cf8bf
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 16:39:48 2025 +0100

    Merge remote-tracking branch 'origin/develop' into bugfix/rey/csv-export-fail

commit cdb39bc
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 16:20:36 2025 +0100

    🐛 preparing folder for wells CSV outputs

commit ab2f726
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 15:45:24 2025 +0100

    🎨 code style & comments

commit 84c3166
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 15:10:33 2025 +0100

    🔇 removing (alot of) debug logs

commit c7416ee
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 14:40:16 2025 +0100

    🎨 uniformize Path.xpp code style

commit 2089fb6
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 14:40:03 2025 +0100

    💄 using relative paths in table titles

commit 6fa19da
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 19 11:44:54 2025 +0100

    ✨ adding unit / source details in title (and shortened header columns/row by using standard variables) + possibility to change column/row major convention for table2Ds

commit a1730c8
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Feb 18 17:10:29 2025 +0100

    🐛🎨 fixing how title length is taken into account + clearer variable names & types

commit 82e6a5d
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Feb 18 11:48:05 2025 +0100

    🐛 crash fix for tables that have no content

commit a5bc751
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Feb 18 11:46:56 2025 +0100

    ✨ adding support for multiline table titles + improved code style

commit 3c145ed
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Feb 18 11:24:26 2025 +0100

    debug lines

commit f838fab
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Feb 11 15:14:24 2025 +0100

    ⚰️ dead code

commit 13bd003
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Feb 11 15:13:49 2025 +0100

    🎨 ensure that all TableFunction pointers are properly initialized

commit fea6188
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Tue Feb 11 14:06:49 2025 +0100

    📝 docs update

commit 28965f5
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 6 12:00:48 2025 +0100

    📦 our favorite generated files

commit 34ed767
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 6 10:19:39 2025 +0100

    📝 Clarifying a bit getLogLevel() documentation

commit 6814ec8
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Thu Feb 6 10:18:21 2025 +0100

    🎨 🐛 bug & name fix (removing any pvt concept from TableFunction)

commit be7c981
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 5 17:56:57 2025 +0100

    ♻️ refactor a bit table header & code clarity

commit 3b6e6f0
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 5 17:55:22 2025 +0100

    📝 clearer writeCSV message

commit 8d68c37
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 5 17:54:43 2025 +0100

    🐛 Properly ensure we only output from rank 0

commit 55fb7db
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Wed Feb 5 17:52:18 2025 +0100

    ✨ Added ability to output any TableFunction in log / CSV

commit 52dca0a
Author: MelReyCG <melvin.rey@capgemini.com>
Date:   Mon Feb 3 15:18:57 2025 +0100

    Preparing folder for table outputs (CSVs)
    - uniformizing behaviour of TableFunction regarding other outputing components (OutputBase...)
danielemoretto44 pushed a commit that referenced this pull request Sep 22, 2025
* Update tag, add PySolver snippet, adjust lai setting

* Generalize umpire dependency

* Add LAI interface toggle

* Remove uberenv submodule and uberenv/spack configuration files from GEOS repository

* Specify path to ATS python3 executable

* Update docs

* Update docs with info about LC script

* Sherlock changes; adjust hypre/trilinos defaults, make lai setting explicit per job

* disable sherlock unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI flag: no rebaseline Does not require rebaseline flag: ready for review flag: requires updated submodule(s) flag: requires updated TPL(s) Needs a specific TPL PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants