Fix hotkey no csv #533
Open
Fix hotkey no csv #533
+302
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new Windows batch script, `build.bat`, to fully automate the build process described in `BUILDING.md`. The script handles: - Cloning and bootstrapping vcpkg - Installing required vcpkg packages - Building the Chromium Embedded Framework (CEF) from a user-provided directory - Installing NPM dependencies for the UI - Creating and installing a test certificate - Building the main Visual Studio solution This script significantly simplifies the setup for new and existing developers, reducing the chance of manual errors. The `BUILDING.md` file has also been updated to document the usage of this new script.
This commit corrects the download URL for the Chromium Embedded Framework (CEF) dependency in the GitHub Actions CI workflow. The previous URL pointed to version 139, which was incorrect. This has been updated to point to the correct version 136, as specified in the project's build documentation. The cache key for the CEF dependency has also been updated from `v139` to `v136` to reflect this change.
fix: Update CEF download link in CI workflow
This commit fixes a bug where the `--hotkey` command-line argument was ignored when `--no_csv` was also specified. The `CommandLine.cpp` file has been modified to remove the logic that disabled hotkey support when CSV output was disabled. A test case has been added to `Tests/CommandLineTests.cpp` to verify that the hotkey functionality works as expected when `--no_csv` is used. Note: Due to issues with the build environment, I was unable to compile and run the tests to verify the fix. The test case has been implemented based on the code review feedback and is expected to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug where the --hotkey command-line argument was incorrectly disabled when the --no_csv flag was used. This prevented users from using hotkeys to control recording unless a CSV file was being generated.
The fix removes the logic in CommandLine.cpp that erroneously linked hotkey support to CSV output, ensuring that hotkeys function independently.
Verification
To confirm the fix, a new unit test, HotkeyWithoutCsv, has been added to Tests/CommandLineTests.cpp. This test:
This test was added to address the code review feedback and ensure the fix is verifiable.
Note: While the fix and the corresponding test case have been implemented, I was unable to compile and run the test suite due to persistent build environment issues. The changes are logically sound, but will require verification by running the tests in a configured environment.