Skip to content

implement dpnp.bitwise_count #2308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Mar 4, 2025
Merged

implement dpnp.bitwise_count #2308

merged 15 commits into from
Mar 4, 2025

Conversation

@vtavana
Copy link
Contributor

@vtavana vtavana commented Feb 11, 2025 •
edited
Loading

In this PR, dpnp.bitwise_count is implemented using SYCL built-in function sycl::popcount.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

ndgrigorian
ndgrigorian reviewed Feb 11, 2025
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Feb 11, 2025 •
edited
Loading

Array API standard conformance tests for dpnp=0.18.0dev0=py312he4f9c94_35 ran successfully.
Passed: 1006
Failed: 0
Skipped: 17

@vtavana vtavana marked this pull request as ready for review February 11, 2025 22:52
antonwolfy
antonwolfy reviewed Feb 12, 2025
View reviewed changes
@coveralls
Copy link
Collaborator

coveralls commented Feb 14, 2025 •
edited
Loading

Coverage Status

coverage: 71.94% (+0.01%) from 71.929%
when pulling 3451a1e on impl-bitwise_count
into 9d212b3 on master.

@antonwolfy antonwolfy added this to the 0.18.0 release milestone Feb 26, 2025
antonwolfy
antonwolfy approved these changes Mar 4, 2025
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana. Only one more minor comment from.

@vtavana vtavana merged commit b91e43b into master Mar 4, 2025
65 of 67 checks passed
@vtavana vtavana deleted the impl-bitwise_count branch March 4, 2025 20:19
github-actions bot added a commit that referenced this pull request Mar 4, 2025
@github-actions
implement dpnp.bitwise_count (#2308)
eb8ecb9 
In this PR, `dpnp.bitwise_count` is implemented using [SYCL built-in
function](https://registry.khronos.org/SYCL/specs/sycl-2020/html/sycl-2020.html#api:popcount)
`sycl::popcount`. b91e43b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndgrigorian ndgrigorian ndgrigorian left review comments

@antonwolfy antonwolfy antonwolfy approved these changes

@AlexanderKalistratov AlexanderKalistratov Awaiting requested review from AlexanderKalistratov

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@vtavana vtavana

Labels

None yet

Projects

None yet

Milestone

0.18.0 release

Development

Successfully merging this pull request may close these issues.

4 participants

@vtavana @coveralls @ndgrigorian @antonwolfy