-
Notifications
You must be signed in to change notification settings - Fork 8
fix blossom #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix blossom #11
Conversation
|
@etiennedeg , could you check whether the switch to LEMONGraphs.jl is fixing this? If you have a chance to rebase, I will be prompt to review. |
|
I briefly looked into this, but I don't know what behavior is expected from LEMON if no matching exists. I wanted to check the |
|
The wrapper is bundled with the build script for LEMON in Yggdrasil: https://github.com/JuliaPackaging/Yggdrasil/blob/master/L/LEMON/bundled/cxxwrap/lemoncxxwrap.cpp And then the wrapping happens here: https://github.com/JuliaGraphs/LEMONGraphs.jl/blob/main/src/LEMONGraphs.jl The wrapper is so minimal because my goal was just to make GraphsMatching installable on all systems where BlossomV.jl fails to install, so I just matched the minimal existing capabilities. Could you run me through what other API you need access to? I can try to enable it. |
|
The official docs did not load for me. Here is the waybackmachine archive https://web.archive.org/web/20200111124408/https://lemon.cs.elte.hu/pub/doc/1.3.1/a00263.html Do you need anything besides the scalar |
|
I don't know what I need, I'm trying to reverse engineer what happens if there is no matching. So preferably one would have access to all the methods for |
|
I will try to set up a pull request to Yggdrassil that makes these available later in the day and tag you there so you also have an example. Maybe we can work together on this over the next few days (I will not have enough bandwidth to take care of updating LEMONGraphs.jl and GraphsMatching.jl themselves)? |
|
That would be nice, if you can get me started on where to change things I can take it from there. |
|
attempt to wrap these is here JuliaPackaging/Yggdrasil#12376 |
fixes #10