-
Notifications
You must be signed in to change notification settings - Fork 29
Read pulseq 1.5.0 #614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Read pulseq 1.5.0 #614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use three correct logic so pulseq 1.4 still works. No need to pass the version into the get_X functions, you can just check the input length of the library.
phase_ppm = r[8] | ||
freq = r[9] | ||
phase = r[10] | ||
use = r[11] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are not using use
, there's an issue that could be solved by incorporating this information into the RF #613.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #614 +/- ##
==========================================
- Coverage 90.08% 90.08% -0.01%
==========================================
Files 56 56
Lines 3118 3136 +18
==========================================
+ Hits 2809 2825 +16
- Misses 309 311 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
(1) Update get_events to add (2) Test with reader with (take inspiration from https://juliahealth.org/KomaMRI.jl/dev/explanation/5-seq-events/):
@Stockless can you give use the MATLAB files you were using for the tests? (3) Modify to consider new RF uses, to calculate k-space correctly (not guess RF use by > 90.0):
If use is Undefined(), keep using the current method; otherwise, use the provided value. If center is not defined (i.e., == 0.0), keep the current method; otherwise, use the provided value. |
This PR addresses issue #555 by adding support for reading Pulseq files in version 1.5.0.