Development - SDS 3.0 #280
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dependency and avoid security issues
…th-tabs #247 - Add dataset upload tab
…th-tabs #247 - update jest puppeteer, increase allows upload size
…th-tabs #247 - Increase file size allowed on file upload, save debug more on local storage
Fix typo with name Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…el-for-missing-properties feat: include missing metadata properties
…ilView components
…or-folder-hierarchy fix: show folder names without full path in tree
…-splinter.getgraph feat: show primary and derivative folders
…or-folder-hierarchy fix: simplify folder linking and improve node attribute handling in Splinter utility
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ey-md9vwd feat: configure folder icon colors for graph nodes
August Release - SDS 3.0 Support
Co-authored-by: jrmartin <4562825+jrmartin@users.noreply.github.com>
Co-authored-by: jrmartin <4562825+jrmartin@users.noreply.github.com>
Co-authored-by: jrmartin <4562825+jrmartin@users.noreply.github.com>
Co-authored-by: jrmartin <4562825+jrmartin@users.noreply.github.com>
Modified duplicate detection logic to only skip folder creation when the folder is a sparc node AND the parent is NOT that sparc node. This allows primary/derivative folders to be displayed under their sparc node representation while still preventing duplicates elsewhere. For example: - sam-l-seg-c1/primary folder now shows under sam-l-seg-c1 Sample node - But sam-l-seg-c1 does NOT appear as duplicate under sam-l/primary Co-authored-by: jrmartin <4562825+jrmartin@users.noreply.github.com>
Fix duplicate Collection nodes for folders already represented as sparc: entities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modernizes the SDS Viewer’s test and build infrastructure, refactors test utility modules for consistency, and introduces a new debug mode for dataset upload and visibility. The most significant changes are grouped below:
Continuous Integration and Node Environment Updates:
.github/workflows/actions.yml) to use Ubuntu 22.04 and Node.js 18.x, modernizing the CI environment and improving compatibility and security. Also, the workflow now triggers on bothmasteranddevelopmentbranches. [1] [2]package.jsonto the latest major versions ofjest,jest-puppeteer,jest-image-snapshot, andpuppeteer, ensuring improved reliability and future compatibility. The E2E test script was also updated for clarity.Test Utilities Refactor:
selectors.jsandtime_constants.jsfrom ES module exports to CommonJS (module.exports), aligning with the test runner’s requirements and simplifying imports. [1] [2]e2e.test.jsto use CommonJSrequiresyntax, ensuring consistency and compatibility with the refactored utility modules. Also, set the default development URL tohttp://localhost:3000/for local testing.Debug Mode and Dataset Upload Improvements:
README.md, allowing users to upload datasets from local disk and view all datasets regardless of status by using the?debug=trueURL parameter.DatasetsListDialogand related components to support debug mode and enable/disable the upload tab based on props, including logic to handle file uploads and dataset filtering. [1] [2] [3] [4] [5]enableUploadanddebugprops, and removed legacy upload dialog logic. [1] [2]Miscellaneous Fixes and Improvements:
doiinApp.js.mainLayout.jsto properly identify visible child nodes.These changes collectively improve the developer experience, test reliability, and add a powerful debug mode for advanced dataset handling.