-
-
Notifications
You must be signed in to change notification settings - Fork 252
feat: add tracing to multichain account service #7006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5a26cc8 to
3190bca
Compare
ccharly
reviewed
Oct 30, 2025
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountWallet.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
ccharly
reviewed
Oct 31, 2025
packages/multichain-account-service/src/providers/EvmAccountProvider.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/EvmAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/EvmAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/MultichainAccountService.ts
Outdated
Show resolved
Hide resolved
ccharly
reviewed
Nov 5, 2025
packages/multichain-account-service/src/providers/SolAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/SolAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/TrxAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/SnapAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/BtcAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/BtcAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
packages/multichain-account-service/src/providers/SnapAccountProvider.test.ts
Outdated
Show resolved
Hide resolved
fix: lint fix: remove cursor rules
defd4e7 to
d225a86
Compare
ccharly
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds traces to the Multichain Account Service.
References
Checklist
Note
Adds pluggable tracing to account discovery across EVM, Solana, Bitcoin, and Tron providers with a default no-op fallback and service-level configuration.
TraceNameenum andtraceFallbackinsrc/analytics/*with exports.SnapAccountProviderto accept aTraceCallbackand provide a protectedtracewrapper.discoverAccountsin tracing forEvmAccountProvider,SolAccountProvider,TrxAccountProvider, andBtcAccountProvider(defaulting totraceFallback).MultichainAccountServiceaccepts optionalconfig.traceand passes it to providers.MultichainAccountServiceConfigwith optionaltraceand plumb through constructors.SnapAccountProvider(custom vs fallback, empty/error cases).TraceCallbackis passed; minor event emission assertion tightened.CHANGELOG.mdnoting optional tracing configuration.Written by Cursor Bugbot for commit aebc20c. This will update automatically on new commits. Configure here.