chore: add is gasFeeSponsored field in transaction batch params #7064
+46
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
khanti42
force-pushed
the
chore/addIsGasFeeSponsoredField
branch
from
ab5f7a6 to
e983f05
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| >[0] = { | ||
| disable7702, | ||
| isGasFeeIncluded: Boolean(gasIncluded7702), | ||
| isGasFeeSponsored: Boolean(gasSponsored), |
There was a problem hiding this comment.
Bug: Gas Sponsorship Not Reflected in Quote Response
The gasSponsored property is destructured from quoteResponse.quote but it's not included in the quoteResponse parameter type definition. Looking at the context, the function signature shows quoteResponse: Omit<QuoteResponse, 'approval' | 'trade'> & Partial<QuoteMetadata>, but gasSponsored is not part of the quote object's known structure based on the imports from @metamask/bridge-controller. This could result in gasSponsored being undefined and isGasFeeSponsored always being false, even when gas is actually sponsored.
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Battambang
force-pushed
the
chore/addIsGasFeeSponsoredField
branch
from
7b44fb9 to
c307071
Compare
Battambang
previously approved these changes
Nov 7, 2025
vinistevam
previously approved these changes
Nov 7, 2025
matthewwalsh0
requested changes
Nov 7, 2025
| const { result } = await addTransaction(txParams, { | ||
| batchId, | ||
| isGasFeeIncluded: userRequest.isGasFeeIncluded, | ||
| isGasFeeSponsored: userRequest.isGasFeeSponsored, |
Member
There was a problem hiding this comment.
This is only for EIP-7702 flow, do we also want want to pass it for the hook fallback via STX or sequentially?
Contributor
Author
There was a problem hiding this comment.
The requirement is 7702 support from the chain to activate sponsorship. If 7702 is not supported by the chain then sponsorship cannot happen.
Contributor
There was a problem hiding this comment.
Current gas fees sponsored use case is only for EIP-7702 delegation flow.
| const { result } = await addTransaction(txParams, { | ||
| batchId, | ||
| isGasFeeIncluded: userRequest.isGasFeeIncluded, | ||
| isGasFeeSponsored: userRequest.isGasFeeSponsored, |
Member
There was a problem hiding this comment.
Minor, is it worth asserting this is passed in one of the existing unit tests?
matthewwalsh0
approved these changes
Nov 7, 2025
vinistevam
approved these changes
Nov 7, 2025
micaelae
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR introduces a new boolean flag, isGasFeeSponsored, across the Transaction Controller and Bridge Status Controller to indicate when a transaction’s gas fee is sponsored (i.e., paid by MetaMask or another service provider).
This complements the existing isGasFeeIncluded flag, which tracks when the gas cost is embedded within the transaction itself. Together, these flags enable more accurate handling of different gas payment scenarios.
Especially needed for the fully sponsored scenario for SEI and MONAD chain.
References
Checklist
Note
Adds
isGasFeeSponsoredflag end-to-end (types, plumbing, and tests) for transaction batches and addTransaction, and passes quotegasSponsoredthrough BridgeStatusController.isGasFeeSponsoredtoTransactionBatchRequestandAddTransactionOptionsinsrc/types.ts.isGasFeeSponsoredinaddTransaction; pass through inaddTransactionBatch(EIP-7702 path) viautils/batch.ts.isGasFeeSponsoredpropagation (TransactionController.test.ts,utils/batch.test.ts).CHANGELOG.mdnoting new support.gasSponsored=>isGasFeeSponsoredingetAddTransactionBatchParams(src/utils/transaction.ts).isGasFeeSponsored; updateCHANGELOG.md.Written by Cursor Bugbot for commit 0995577. This will update automatically on new commits. Configure here.