Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Nov 6, 2025

Explanation

The ESLint cache feature has known problems with lint rules that depend upon multiple files, such as type-related rules.

See here for more on why it's not advised: https://typescript-eslint.io/troubleshooting/faqs/eslint/#can-i-use-eslints---cache-with-typescript-eslint

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed, highlighting breaking changes as necessary
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

Note

Removes ESLint caching from root and package lint scripts to avoid cache-related issues.

  • Linting:
    • Disable ESLint cache in root package.json by removing --cache from lint:eslint (runs ./scripts/run-eslint.ts).
    • Disable ESLint cache in package lint scripts by removing --cache from eslint invocations in:
      • packages/eth-block-tracker/package.json
      • packages/eth-json-rpc-middleware/package.json
      • packages/eth-json-rpc-provider/package.json
      • packages/json-rpc-engine/package.json

Written by Cursor Bugbot for commit 28ee04d. This will update automatically on new commits. Configure here.

@Gudahtt Gudahtt marked this pull request as ready for review November 7, 2025 12:55
@Gudahtt Gudahtt requested review from a team as code owners November 7, 2025 12:55
The ESLint cache feature has known problems with lint rules that
depend upon multiple files, such as type-related rules.

See here for more on why it's not advised: https://typescript-eslint.io/troubleshooting/faqs/eslint/#can-i-use-eslints---cache-with-typescript-eslint
@Gudahtt Gudahtt force-pushed the do-not-use-eslint-cache-by-default branch from 69f98f4 to 28ee04d Compare November 7, 2025 12:55
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit fa811f9 into main Nov 7, 2025
267 checks passed
@Gudahtt Gudahtt deleted the do-not-use-eslint-cache-by-default branch November 7, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants