Skip to content

Add multi-threaded benchmarks. #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add multi-threaded benchmarks. #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
compiler: ["gcc"]
window: ["kaiserbessel", "gaussian", "bspline", "sinc"] # TODO: Add dirac.
precision_opt: ["", "--enable-float", "--enable-long-double"]
openmp: [0, 1]
openmp: [1]
build_octave: [0] # TODO: Re-activate Octave build and tests.
build_julia: [1]
include:
Expand Down Expand Up @@ -132,7 +132,7 @@ jobs:
if: steps.cache-codspeed.outputs.cache-hit != 'true'
run: |
cd codspeed-cpp/google_benchmark
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBENCHMARK_DOWNLOAD_DEPENDENCIES=ON -DCODSPEED_MODE=instrumentation -DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_EXTENSIONS=OFF.
cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -DBENCHMARK_DOWNLOAD_DEPENDENCIES=ON -DCODSPEED_MODE=instrumentation -DCMAKE_CXX_STANDARD=17 -DCMAKE_CXX_EXTENSIONS=OFF .

- name: Build CodSpeed integration library
if: steps.cache-codspeed.outputs.cache-hit != 'true'
Expand Down
21 changes: 19 additions & 2 deletions benchmarks/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,21 +7,38 @@ bench_nfft_direct_SOURCES = bench_nfft_direct.cpp util.h
bench_nfft_direct_CXXFLAGS = @nfft_benchmarks_CXXFLAGS@ @CXXFLAGS@
bench_nfft_direct_LDFLAGS = @nfft_benchmarks_LDFLAGS@ @fftw3_LDFLAGS@ @LDFLAGS@
bench_nfft_direct_LDADD = @nfft_benchmarks_LIBS@ $(top_builddir)/libnfft3@PREC_SUFFIX@.la @fftw3_LIBS@ @LIBS@
if ENABLE_OPENMP
NFFT_BENCHMARKS_DIRECT_OMP = bench_nfft_direct_omp
bench_nfft_direct_omp_SOURCES = bench_nfft_direct.cpp util.h
bench_nfft_direct_omp_CXXFLAGS = @nfft_benchmarks_CXXFLAGS@ $(OPENMP_CFLAGS) @CXXFLAGS@
bench_nfft_direct_omp_LDFLAGS = @nfft_benchmarks_LDFLAGS@ @fftw3_LDFLAGS@ $(OPENMP_CFLAGS) @LDFLAGS@
bench_nfft_direct_omp_LDADD = @nfft_benchmarks_LIBS@ $(top_builddir)/libnfft3@PREC_SUFFIX@_omp.la @fftw3_LIBS_omp@ @fftw3_LIBS@ $(OPENMP_LIBS)
endif
else
NFFT_BENCHMARKS_DIRECT =
NFFT_BENCHMARKS_DIRECT_OMP =
endif
else
NFFT_BENCHMARKS_DIRECT =
NFFT_BENCHMARKS_DIRECT_OMP =
endif

# Aggregate all benchmarks
NFFT_BENCHMARKS = $(NFFT_BENCHMARKS_DIRECT)

noinst_PROGRAMS = $(NFFT_BENCHMARKS)
if ENABLE_OPENMP
NFFT_BENCHMARKS_OMP = $(NFFT_BENCHMARKS_DIRECT_OMP)
endif

noinst_PROGRAMS = $(NFFT_BENCHMARKS) $(NFFT_BENCHMARKS_OMP)

# Run all built benchmarks
bench: $(NFFT_BENCHMARKS)
bench: $(NFFT_BENCHMARKS) $(NFFT_BENCHMARKS_OMP)
for bench in $(NFFT_BENCHMARKS); do \
echo "Running $$bench..."; \
./$$bench; \
done
for bench in $(NFFT_BENCHMARKS_OMP); do \
echo "Running $$bench..."; \
./$$bench; \
done
60 changes: 47 additions & 13 deletions benchmarks/bench_nfft_direct.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,30 @@

#include "util.h"

#ifdef _OPENMP
#define SUFFIX "_omp"
#else
#define SUFFIX ""
#endif

static void DoSetup(const benchmark::State& state) {
#ifdef _OPENMP
#ifdef HAVE_FFTW_THREADS
FFTW(init_threads)();
#endif
#endif
}

static void DoTeardown(const benchmark::State& state) {
#ifdef _OPENMP
#ifdef HAVE_FFTW_THREADS
FFTW(cleanup_threads)();
#endif
#endif
}

// Helper function to initialize random data
static void NFFT(init_random_data)(NFFT(plan)* plan) {
static void init_random_data(NFFT(plan)* plan) {
NFFT(vrand_shifted_unit_double)(plan->x, plan->d * plan->M_total);
NFFT(vrand_unit_complex)(plan->f_hat, plan->N_total);
NFFT(vrand_unit_complex)(plan->f, plan->M_total);
Expand All @@ -41,7 +63,7 @@ static void nfft_forward_direct_1d(benchmark::State& state) {

NFFT(plan) plan;
NFFT(init_1d)(&plan, N, M);
NFFT(init_random_data)(&plan);
init_random_data(&plan);

for (auto _ : state) {
NFFT(trafo_direct)(&plan);
Expand All @@ -58,7 +80,7 @@ static void nfft_adjoint_direct_1d(benchmark::State& state) {

NFFT(plan) plan;
NFFT(init_1d)(&plan, N, M);
NFFT(init_random_data)(&plan);
init_random_data(&plan);

for (auto _ : state) {
NFFT(adjoint_direct)(&plan);
Expand All @@ -76,7 +98,7 @@ static void nfft_forward_direct_2d(benchmark::State& state) {

NFFT(plan) plan;
NFFT(init_2d)(&plan, N1, N2, M);
NFFT(init_random_data)(&plan);
init_random_data(&plan);

for (auto _ : state) {
NFFT(trafo_direct)(&plan);
Expand All @@ -94,7 +116,7 @@ static void nfft_adjoint_direct_2d(benchmark::State& state) {

NFFT(plan) plan;
NFFT(init_2d)(&plan, N1, N2, M);
NFFT(init_random_data)(&plan);
init_random_data(&plan);

for (auto _ : state) {
NFFT(adjoint_direct)(&plan);
Expand All @@ -113,7 +135,7 @@ static void nfft_forward_direct_3d(benchmark::State& state) {

NFFT(plan) plan;
NFFT(init_3d)(&plan, N1, N2, N3, M);
NFFT(init_random_data)(&plan);
init_random_data(&plan);

for (auto _ : state) {
NFFT(trafo_direct)(&plan);
Expand All @@ -132,7 +154,7 @@ static void nfft_adjoint_direct_3d(benchmark::State& state) {

NFFT(plan) plan;
NFFT(init_3d)(&plan, N1, N2, N3, M);
NFFT(init_random_data)(&plan);
init_random_data(&plan);

for (auto _ : state) {
NFFT(adjoint_direct)(&plan);
Expand All @@ -143,44 +165,56 @@ static void nfft_adjoint_direct_3d(benchmark::State& state) {
}

// Register benchmarks for direct transforms
BENCH(nfft_forward_direct_1d)
BENCH(nfft_forward_direct_1d, SUFFIX)
->Args({32, 100})
->Args({64, 200})
->Args({128, 400})
->Args({256, 800})
->Args({512, 1600})
->Setup(DoSetup)
->Teardown(DoTeardown)
->Complexity();

BENCH(nfft_adjoint_direct_1d)
BENCH(nfft_adjoint_direct_1d, SUFFIX)
->Args({32, 100})
->Args({64, 200})
->Args({128, 400})
->Args({256, 800})
->Args({512, 1600})
->Setup(DoSetup)
->Teardown(DoTeardown)
->Complexity();

BENCH(nfft_forward_direct_2d)
BENCH(nfft_forward_direct_2d, SUFFIX)
->Args({16, 16, 500})
->Args({32, 32, 1000})
->Args({64, 64, 2000})
->Setup(DoSetup)
->Teardown(DoTeardown)
->Complexity();

BENCH(nfft_adjoint_direct_2d)
BENCH(nfft_adjoint_direct_2d, SUFFIX)
->Args({16, 16, 500})
->Args({32, 32, 1000})
->Args({64, 64, 2000})
->Setup(DoSetup)
->Teardown(DoTeardown)
->Complexity();

BENCH(nfft_forward_direct_3d)
BENCH(nfft_forward_direct_3d, SUFFIX)
->Args({4, 4, 4, 250})
->Args({8, 8, 8, 500})
->Args({16, 16, 16, 1000})
->Setup(DoSetup)
->Teardown(DoTeardown)
->Complexity();

BENCH(nfft_adjoint_direct_3d)
BENCH(nfft_adjoint_direct_3d, SUFFIX)
->Args({4, 4, 4, 250})
->Args({8, 8, 8, 500})
->Args({16, 16, 16, 1000})
->Setup(DoSetup)
->Teardown(DoTeardown)
->Complexity();

// Main function.
Expand Down
2 changes: 1 addition & 1 deletion benchmarks/util.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,6 @@
#include "config.h"

// Macro to register benchmark with optional prefix
#define BENCH(function) BENCHMARK(function)->Name("benchmarks/" __FILE__ "::" BENCHMARKS_PREFIX #function)
#define BENCH(function, suffix) BENCHMARK(function)->Name("benchmarks/" __FILE__ "::" BENCHMARKS_PREFIX #function suffix)

#endif // NFFT_BENCHMARKS_UTIL_H
Loading