feat: add moderation commands #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returns the first element in the iterable that meets
all the traits passed in attrs.
Contributor
Author
|
This will close #6 when merged! |
Changes timeout command from individual to a group command and add timeout disable function
… moderation roles
…by passing no role in the config command
…docstrings to explain the parameters
…nition of the function
…onous and remove unnecessary import This commit adds docstrings to some of the functions and removes asynchronous function definition from the `higher_role_check` function as it was redundant to do so and also it removes some of the unnecessary imports in the file
This commit removes asynchronous function definition from `role_check` and `has_permissions` function as they are unnecessary and no async/await was found in the function making it redundant.
…bot.core.plugins.Admin.admin`
…ebot.core.utils.errors`
CaffeineDuck
requested changes
Jan 30, 2022
Contributor
CaffeineDuck
left a comment
CaffeineDuck
left a comment
There was a problem hiding this comment.
I have added some suggestions and some questions in the code changes, hoping for your explanation or code changes soon. @thenishantsapkota
| @lightbulb.command("enable", "Timeout a member from the server") | ||
| @lightbulb.implements(lightbulb.SlashSubCommand, lightbulb.PrefixSubCommand) | ||
| @moderation_role_check | ||
| async def timeout_enable_command(ctx: lightbulb.Context) -> None: |
Contributor
There was a problem hiding this comment.
The code is clean even though it's multiline, it's uses helper and reusable functions so it's good.
But you aren't leaving any spacing at all, It'd be better if you leave spaced after 44 or 46, so that it's clear for the code viewer and the code looks clean.
…ikari-lightbulb`
…lightbulb would break it
Also changed the paginator from Lightbulb to Miru
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.