Add user poison functions #494
Open
+82
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Gentle ping. |
ampandey-AMD
reviewed
Nov 8, 2025
| if (size == 0) | ||
| return; | ||
|
|
||
| uptr beg_addr = (uptr)addr; |
There was a problem hiding this comment.
Can the value of input addr be 0x0?
There was a problem hiding this comment.
Is a check guard required here foraddr, or the value would always be non-null as it is not an external api where a user could call this function for negative testing?
Author
There was a problem hiding this comment.
A check is not required. No attempt is made to dereference addr, and shadow for address 0 exists.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.