Fix running Duels on MC 1.21+ #120
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also upgraded gradle to allow using Java 21
|
1.21.1? |
Author
|
Didn't test yet but I'm fairly sure nothing changed and it will work the same |
|
it will not work for 1.20.5+ as minecraft changed some stuff |
|
use my fork if you wanna run it on 1.21 |
Author
No, it works fine on 1.21, I meant nothing changed from 1.21 to 1.21.1 but actually the version parsing had an issue, it's fixed now. |
|
Have you tested running it on 1.21? |
Author
Read my previous reply, already said so, yes it works. |
|
Hi bro, working for 1.21.4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's probably an easier way to get the version but this seems to work.
Also upgraded gradle to allow compiling using Java 21.
Releases here if anyone needs it:
https://github.com/ChanceSD/Duels/releases