Edit orientation on spawning #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/quaternion_utils.h
Outdated
| { | ||
| tf2::Quaternion q; | ||
|
|
||
| if (axis.length() > 1e-6) |
There was a problem hiding this comment.
I do not understand what this is trying to to do. Is it an epsilon check? If so consider using <limits>.
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
jhanca-robotecai
force-pushed
the
jh/add_spawn_orientation
branch
from
f72ba4a to
33761b9
Compare
|
Rebased and ready for the review |
Signed-off-by: Jan Hanca <jan.hanca@robotec.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to rotate object when spawning - added the same way as for
SetEntityState, i.e. the rotation vector + angle in degTwo decals spawned at 5,0,0 no rotation and 7,0,0 with 90 rot around Z:
UI (changes marked with red rectangle):
Note: PR #7 should be merged first