Fix unused shared memory failing validation #456
+126
−67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes validation errors caused by unused shared memory and enables it to be DCE-ed away.
Params of entry point interfaces will now be DCE-ed by rust-gpu as well, previously only
spirv-optdoes some DCE on them but it leaves unused shared memory params as-is. As withspirv-opt,SpirvBuilder.optimizer.preserve_bindings = truewill disable any DCE of unused entry point params.On a vulkan1.1/spv1.3 or lower
preserve_bindingsdoes not work on any param that is not of class input or output, so shared memory will be DCE-ed anyway, due to there being no references to those instructions. Whereas vulkan1.2+/spv1.4+ added the requirement for allOpVariables to be mentioned in the entry point instruction, allowing us to preserve them.close #455