polish 😁 #5
Open
polish 😁 #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rnal package Move webhook implementation from api/v1alpha1 to internal/webhook package following Kubebuilder best practices for webhook organization. Implement proper defaulting for component images through webhook defaulter instead of hardcoding fallbacks in controller. Changes: - Move SupabaseProjectWebhook to internal/webhook package - Add wellknown_supabase_images.go with centralized default image constants - Implement Default() method to set component image defaults - Simplify controller by using spec.Component.Image directly - Update webhook registration in main.go This improves separation of concerns and ensures image defaults are set at admission time rather than reconciliation time. Co-Authored-By: Claude <noreply@anthropic.com>
Restructure resource management by introducing a ComponentBuilder interface and ComponentReconciler to standardize component lifecycle management across all Supabase services. Changes: - Rename internal/resources package to internal/component - Add ComponentBuilder interface with BuildDeployment/BuildService - Create ComponentReconciler for unified reconciliation logic - Update all component implementations to use new abstraction - Refactor SupabaseProjectController to leverage ComponentReconciler This improves code maintainability and reduces duplication in the reconciliation logic for Kong, Auth, PostgREST, Realtime, Storage, Meta, and Studio components. Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.