-
Notifications
You must be signed in to change notification settings - Fork 127
SLE-1276 Migrate Eclipse to GitHub #946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some minor comments 😉
.../src/test/java/org/sonarlint/eclipse/core/internal/jobs/AnalyzeStandaloneProjectJobTest.java
Show resolved
Hide resolved
It seems you don't use the iBuilds axis at all anymore with the move to GitHub Actions. You could create a new action, only to be triggered by the user (which was not possible with Cirrus CI), and then trigger the iBuilds build. Or remove the axis completely including the Eclipse Target Platform definition. |
Hi Tobias, iBuilds was not working with cirrus and it is not in the scope of migration effort. We have a separate task https://sonarsource.atlassian.net/jira/software/c/projects/SLCORE/boards/1527?quickFilter=4014 for this. |
SLE-1276