Revert throw removal in FindBytesProperty #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KMojek
approved these changes
May 12, 2025
Contributor
KMojek
left a comment
KMojek
left a comment
There was a problem hiding this comment.
I see the first exception gets hit while looking for moov.trak[0].mdia.minf.stbl.stsd.avc1.reserved3 which seems to related to finding the pixel aspect ratio. We don't set that for TRECs. So I think it likely is getting hit by some other code on Mac for some reason. Seems fine to merge.
Contributor
|
FWIW, the file associated with https://github.com/TechSmith/CamtasiaWin/issues/24505 doesn't appear to hit this code. So it unlikely was needed to begin with. Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from 7104b13
This throw was being relied on in GetTrackESConfiguration:
If one string wasn't found it would catch and try another. That's the one that actually works for decoding audio on macOS apparently:
This makes me think we should revert the rest of that commit, but I can't find anything else like this in mp4file.cpp at least