fix: Missing Delete key handlers #2126
Open
+152
−37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds some additional handling for the Delete key that already exists for the Backspace key.
Rationale
MacOS keyboards don't relaly have a delete key, but Windows keyboards do and it's a fairly commonly used key, so it makes sense to have better support for it.
Changes
getNextBlockInfohelper.Impact
N/A
Testing
TODO? We also have pretty limited tests for Backspace handling. I'm a bit hesitant to add them though as they would currently have to be e2e tests, so would prefer to set up component testing first.
Screenshots/Video
N/A
Checklist
Additional Notes