Skip to content

Upgrade to PHP 8 and refactor to PSR Interfaces #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Upgrade to PHP 8 and refactor to PSR Interfaces #59

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1377ddb
Remove specific cache implementation dependency
janolivermr Oct 27, 2025
1daad07
Bump php version to 8
janolivermr Oct 27, 2025
0103739
Run rector with PHP 8 rules
janolivermr Oct 27, 2025
0e83c41
Refactor phpunit configuration
janolivermr Oct 28, 2025
8113815
Make Logger optional and remove Monolog
janolivermr Oct 28, 2025
54ea1b7
Fix the type errors suggested by PHPStan level 5
janolivermr Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/phpunit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ jobs:
runs-on: ubuntu-20.04
strategy:
matrix:
php-versions: ['7.3', '7.4', '8.0', '8.1']
php-versions: ['8.0', '8.1', '8.2', '8.3', '8.4']

name: PHPUnit ${{ matrix.php-versions }}

Expand Down
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@

*.cache
composer.lock

.idea/
14 changes: 7 additions & 7 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,26 +10,26 @@
],
"minimum-stability": "stable",
"require": {
"php": ">=7.2.0",
"php": ">=8.0",
"ext-curl": "*",
"ext-json": "*",
"ext-zip": "*",
"composer/semver": "^3.0",
"desarrolla2/cache": "^3.0",
"monolog/monolog": "^2.1",
"psr/log": "^1.0|^2.0|^3.0"
"psr/log": "^1.0|^2.0|^3.0",
"psr/simple-cache": "^1.0|^2.0|^3.0"
},
"require-dev": {
"roave/security-advisories": "dev-master",
"phpunit/phpunit": "^9.5"
"monolog/monolog": "^3.9",
"phpunit/phpunit": "^9.5",
"roave/security-advisories": "dev-master"
},
"autoload": {
"psr-4": {
"VisualAppeal\\": "src/"
}
},
"scripts": {
"test": "phpunit -c tests/UnitTests.xml"
"test": "phpunit"
},
"config": {
"sort-packages": true
Expand Down
4 changes: 1 addition & 3 deletions example/client/update/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,7 @@
echo 'New Version: ' . $update->getLatestVersion() . '<br>';
echo 'Installing Updates: <br>';
echo '<pre>';
var_dump(array_map(function ($version) {
return (string) $version;
}, $update->getVersionsToUpdate()));
var_dump(array_map(fn($version) => (string) $version, $update->getVersionsToUpdate()));
echo '</pre>';

// Optional - empty log file
Expand Down
27 changes: 27 additions & 0 deletions phpunit.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
<?xml version="1.0" encoding="UTF-8"?>
<phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.6/phpunit.xsd"
bootstrap="vendor/autoload.php"
cacheResultFile=".phpunit.cache/test-results"
executionOrder="depends,defects"
forceCoversAnnotation="true"
beStrictAboutCoversAnnotation="true"
beStrictAboutOutputDuringTests="true"
beStrictAboutTodoAnnotatedTests="true"
convertDeprecationsToExceptions="true"
failOnRisky="true"
failOnWarning="true"
verbose="true">
<testsuites>
<testsuite name="unit">
<directory>tests</directory>
</testsuite>
</testsuites>

<coverage cacheDirectory=".phpunit.cache/code-coverage"
processUncoveredFiles="true">
<include>
<directory suffix=".php">src</directory>
</include>
</coverage>
</phpunit>
Loading