Skip to content

Add bf16 to munge #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: feature/backport_ea1_ops
Choose a base branch
from
Open

Add bf16 to munge #601

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/RefBackend/RefBackend.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include "mlir/Dialect/Math/Transforms/Passes.h"
#include "mlir/Dialect/Tensor/IR/Tensor.h"
#include "mlir/Dialect/Tensor/Transforms/Transforms.h"
#include "mlir/IR/BuiltinTypes.h"
#include "mlir/Transforms/DialectConversion.h"
#include "mlir/Transforms/GreedyPatternRewriteDriver.h"
#include "torch-mlir/Dialect/TorchConversion/IR/TorchConversionOps.h"
Expand Down Expand Up @@ -56,7 +57,7 @@ void mlir::torch::RefBackend::registerRefBackendPasses() { ::registerPasses(); }
static bool isArgMemRefTypeValid(Type type) {
if (auto memRefType = dyn_cast<MemRefType>(type)) {
Type elemTy = memRefType.getElementType();
if (isa<Float16Type, Float32Type, Float64Type>(elemTy)) {
if (isa<Float16Type, Float32Type, Float64Type, BFloat16Type>(elemTy)) {
return true;
} else if (auto integerTy = dyn_cast<IntegerType>(elemTy)) {
if (integerTy.isSignlessInteger(64))
Expand Down Expand Up @@ -90,6 +91,8 @@ static Type getAbiTypeForMemRef(Type type) {
static std::string getTypeToken(Type type) {
if (type.isSignlessInteger())
return ("i" + Twine(type.getIntOrFloatBitWidth())).str();
else if (isa<mlir::BFloat16Type>(type)) // only the 16 size exists in mlir
return "bf16";
else if (isa<mlir::FloatType>(type))
return ("f" + Twine(type.getIntOrFloatBitWidth())).str();
else if (auto complexTy = dyn_cast<mlir::ComplexType>(type))
Expand Down Expand Up @@ -150,10 +153,10 @@ static LogicalResult mungeFunction(
auto type = arg.getType();
if (!isArgMemRefTypeValid(type)) {
return emitError(arg.getLoc())
.append("argument must be a memref of f32, f64, i32, i64, i8, i1, "
"c32, c64, but "
"got ",
type);
.append(
"argument must be a memref of f32, f64, bf16, i32, i64, i8, i1, "
"c32, c64, but got ",
type);
}
auto cast = b.create<memref::CastOp>(arg.getLoc(), type, arg);
arg.replaceAllUsesExcept(cast, cast);
Expand Down
Loading