Skip to content

replace & with unescaped ampersand in brain viewers #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

replace & with unescaped ampersand in brain viewers #300

wants to merge 3 commits into from

Conversation

@MontrealSergiy
Copy link
Contributor

@MontrealSergiy MontrealSergiy commented Apr 3, 2025 •
edited
Loading

@MontrealSergiy MontrealSergiy self-assigned this Apr 3, 2025
@MontrealSergiy MontrealSergiy mentioned this pull request Apr 3, 2025
Open
@MontrealSergiy
Copy link
Contributor Author

MontrealSergiy commented Apr 3, 2025 •
edited
Loading

I'd url-encode params, but the issue itself is fixed

@prioux
Copy link
Member

prioux commented Apr 3, 2025

I think this is correct, but can you double check why at one place you have only "j" and not "raw j" ?

@MontrealSergiy
Copy link
Contributor Author

MontrealSergiy commented Apr 3, 2025

just a typo, fixed

@MontrealSergiy MontrealSergiy linked an issue Jun 13, 2025 that may be closed by this pull request
URLs are built incorrectly in some content viewers #304
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prioux prioux Awaiting requested review from prioux

@natacha-beck natacha-beck Awaiting requested review from natacha-beck

Assignees

@MontrealSergiy MontrealSergiy

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

URLs are built incorrectly in some content viewers

2 participants

@MontrealSergiy @prioux