Skip to content

Add tests for template file syntax errors #3962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Add tests for template file syntax errors #3962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3aef228
Add tests for making sure that template files have no syntax errors
salmanmkc Jul 27, 2025
f06a452
update with temp file
salmanmkc Jul 27, 2025
c824407
better validations
salmanmkc Jul 27, 2025
63ada10
update
salmanmkc Jul 27, 2025
ffc2086
skip win 64
salmanmkc Jul 27, 2025
2dc3c3a
Enhance shell script validation with detailed debugging and ShellChec…
salmanmkc Jul 28, 2025
577c73e
don't skip on windows
salmanmkc Jul 28, 2025
49b30c8
add skip back for windows
salmanmkc Jul 28, 2025
1f9418d
update
salmanmkc Jul 28, 2025
820bcaf
Update generic methdod to shelcheck all files that can be
salmanmkc Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/Misc/layoutbin/update.sh.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,8 @@ fi
# fix upgrade issue with macOS when running as a service
attemptedtargetedfix=0
currentplatform=$(uname | awk '{print tolower($0)}')
if [[ "$currentplatform" == 'darwin' && $restartinteractiverunner -eq 0 ]]; then
if [[ "$currentplatform" == 'darwin' && $restartinteractiverunner -eq 0 ]];
then
# We needed a fix for https://github.com/actions/runner/issues/743
# We will recreate the ./externals/nodeXY/bin/node of the past runner version that launched the runnerlistener service
# Otherwise mac gatekeeper kills the processes we spawn on creation as we are running a process with no backing file
Expand Down Expand Up @@ -217,4 +218,4 @@ if [ $restartinteractiverunner -ne 0 ]
then
date "+[%F %T-%4N] Restarting interactive runner" >> "$logfile.succeed" 2>&1
"$rootfolder/run.sh" &
fi
fi
Loading
Loading