-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[installdependencies.sh] refactor: support microdnf
, handle .deb installation errors
#4040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the dependency installation script to improve reliability, modernize package manager support, and handle errors more gracefully. The changes focus on better error handling, broader package manager compatibility, and updated dependency lists.
Key changes:
- Added strict error handling with
set -e -o pipefail
and improved conditional checks - Consolidated RedHat-based package manager detection to support
dnf
,yum
, andmicrodnf
- Updated dependency lists to include newer library versions (libssl3, libicu74/73)
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.
This PR:
dnf
code, sincednf
has basically replacedyum
on all RedHat variantsmicrodnf
, used by eg minimal RockyLinux imagesInstallation test logs are available at https://gist.github.com/konstruktoid/438fa3abdaf787b3e5bcd36935764f0d