Skip to content

Conversation

konstruktoid
Copy link

This PR:

Installation test logs are available at https://gist.github.com/konstruktoid/438fa3abdaf787b3e5bcd36935764f0d

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
@Copilot Copilot AI review requested due to automatic review settings September 15, 2025 11:37
@konstruktoid konstruktoid requested a review from a team as a code owner September 15, 2025 11:37
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the dependency installation script to improve reliability, modernize package manager support, and handle errors more gracefully. The changes focus on better error handling, broader package manager compatibility, and updated dependency lists.

Key changes:

  • Added strict error handling with set -e -o pipefail and improved conditional checks
  • Consolidated RedHat-based package manager detection to support dnf, yum, and microdnf
  • Updated dependency lists to include newer library versions (libssl3, libicu74/73)

Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Signed-off-by: Thomas Sjögren <konstruktoid@users.noreply.github.com>
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

konstruktoid and others added 3 commits September 15, 2025 14:09
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant