Path with space fix #4052
Open
Path with space fix #4052
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where script paths containing spaces were not properly quoted, which could cause script execution failures. The fix ensures that all script paths are wrapped in double quotes while properly escaping any existing quotes in the path.
- Wraps script paths in double quotes to handle paths with spaces
- Properly escapes existing quotes in the path before adding outer quotes
- Adds unit tests to verify the quoting behavior for paths with spaces
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Runner.Worker/Handlers/ScriptHandler.cs | Wraps script paths in quotes to handle paths containing spaces |
| src/Test/L0/Worker/Handlers/ScriptHandlerL0.cs | Adds unit test to verify proper quoting of script paths with spaces |
…for quoting environment variables in scripts
Remove duplicate 'using GitHub.Runner.Worker.Container;' statement that was causing compilation error CS0105.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There seems to sometimes be occasions where having a space in a path will cause panic/through a runtime error. This PR should allow spaces to work, however this is a change quite imfactful so I will need to test this in many different scenarios before rolling it out.