Skip to content

Conversation

timfel
Copy link
Contributor

@timfel timfel commented May 28, 2024

Description:
This adds two things:

  1. Windows builds of GraalPy are now available that are useful enough to enable for users. Some minor fixes to our scripts were needed, tests were updated to run on Windows as well.
  2. We make early access builds of upcoming versions available in a separate repository, these are now also available.

Related issue:
#693 and the question after Windows support by @kurtmckee in #694 (comment)

Check list:

  • [ ] Mark if documentation changes are required. None required.
  • Mark if tests were added or updated to cover the changes.

@timfel timfel force-pushed the tim/graalpy-windows-ea branch from b23752b to fc9bcb4 Compare May 28, 2024 17:52
@timfel timfel marked this pull request as ready for review May 28, 2024 17:58
@timfel timfel requested a review from a team as a code owner May 28, 2024 17:58
@timfel
Copy link
Contributor Author

timfel commented Jun 10, 2024

Friendly ping :)

1 similar comment
@timfel
Copy link
Contributor Author

timfel commented Jun 21, 2024

Friendly ping :)

@timfel
Copy link
Contributor Author

timfel commented Jul 1, 2024

Anything I can or should add to this PR in terms of explanation or otherwise?

@timfel
Copy link
Contributor Author

timfel commented Jul 10, 2024

Hi @dmitry-shibanov, since you reviewed the original GraalPy PR, maybe you have a chance to look at this?

@timfel
Copy link
Contributor Author

timfel commented Jul 18, 2024

Friendly ping :) Would be great to get this in so people can easily start testing against GraalPy on Windows

@priya-kinthali
Copy link
Contributor

Hello @timfel 👋,
Thank you for creating this Pull request, we will review and get back to you once we have some feedback on this.

@timfel
Copy link
Contributor Author

timfel commented Aug 21, 2024

Hi @priya-kinthali, any news from your side? Anything I can help with :)

@timfel
Copy link
Contributor Author

timfel commented Oct 10, 2024

It's been a while, friendly ping :-)

@timfel
Copy link
Contributor Author

timfel commented Nov 5, 2024

I resolved the merge conflict, any news?

@timfel
Copy link
Contributor Author

timfel commented Dec 4, 2024

Friendly ping 🔔 😄

@timfel
Copy link
Contributor Author

timfel commented Jan 8, 2025

Happy new year! Any news if you might have time to look at this?

@fniephaus
Copy link

Is there any way one of you could help integrate this, @aparnajyothi-y or @HarithaVattikuti?

@timfel
Copy link
Contributor Author

timfel commented Mar 14, 2025

@priya-kinthali Friendly ping :)

1 similar comment
@timfel
Copy link
Contributor Author

timfel commented Mar 27, 2025

@priya-kinthali Friendly ping :)

@aparnajyothi-y
Copy link
Contributor

Hello Everyone, Thank you for this pull request. We are looking into it and will get back to you once we have some feedback on this :)

@masklinn masklinn mentioned this pull request May 4, 2025
@timfel
Copy link
Contributor Author

timfel commented Jun 18, 2025

Friendly ping :)

@fniephaus
Copy link

@aparnajyothi-y please let us know if there is anything we can help with. In case it helps, GraalPy EA builds are released under GFTC, the same license as Oracle GraalVM, which is integrated into setup-java.

@mahabaleshwars
Copy link
Contributor

Thank you for this contribution, @timfel! 👋

We've started looking into this PR for reviewing. This looks like a valuable addition to support GraalPy Windows builds and early access versions.

We'll review the changes to the scripts and test updates, and provide feedback soon. Appreciate your patience!

@mahabaleshwars
Copy link
Contributor

Hi @timfel,

To help us get this merged, could you please:

  1. Rebase or merge the latest changes from the main branch into your PR
  2. Address any CI failures that arise after merging the latest changes
    Once the CI checks are passing, we'll be able to review and merge this quickly.

Please let me know if you need any assistance with resolving conflicts or CI issues – I'm happy to help!

Thanks again for your work on this!

@Copilot Copilot AI review requested due to automatic review settings October 15, 2025 08:34
@timfel timfel force-pushed the tim/graalpy-windows-ea branch from 9c4618d to c884be3 Compare October 15, 2025 08:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds Windows support and early access builds for GraalPy installations. The changes enable Windows builds which are now considered stable enough for users and make early access builds from a separate repository available.

Key changes include:

  • Adding Windows support with zip extraction and proper binary path handling
  • Including early access builds from the graal-languages-ea-builds repository
  • Updating tests to run on Windows and use new version patterns

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/utils.ts Updated comment to remove GraalPy reference since it now has Windows-specific handling
src/install-graalpy.ts Added Windows zip extraction, early access builds fetching, and updated version pattern matching
src/find-graalpy.ts Simplified binary path logic to use consistent 'bin' directory approach
tests/install-graalpy.test.ts Updated test cases for new version patterns and enabled Windows testing
tests/find-graalpy.test.ts Removed Windows test skipping and updated version references
.github/workflows/test-graalpy.yml Added Windows to the test matrix

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@timfel timfel force-pushed the tim/graalpy-windows-ea branch from c884be3 to 84a937d Compare October 15, 2025 08:45
@timfel timfel force-pushed the tim/graalpy-windows-ea branch from 84a937d to be60ae8 Compare October 16, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants