-
Notifications
You must be signed in to change notification settings - Fork 663
Add graalpy early-access and windows builds #880
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
b23752b
to
fc9bcb4
Compare
Friendly ping :) |
1 similar comment
Friendly ping :) |
Anything I can or should add to this PR in terms of explanation or otherwise? |
Hi @dmitry-shibanov, since you reviewed the original GraalPy PR, maybe you have a chance to look at this? |
Friendly ping :) Would be great to get this in so people can easily start testing against GraalPy on Windows |
Hello @timfel 👋, |
Hi @priya-kinthali, any news from your side? Anything I can help with :) |
It's been a while, friendly ping :-) |
I resolved the merge conflict, any news? |
Friendly ping 🔔 😄 |
Happy new year! Any news if you might have time to look at this? |
Is there any way one of you could help integrate this, @aparnajyothi-y or @HarithaVattikuti? |
@priya-kinthali Friendly ping :) |
1 similar comment
@priya-kinthali Friendly ping :) |
Hello Everyone, Thank you for this pull request. We are looking into it and will get back to you once we have some feedback on this :) |
Friendly ping :) |
@aparnajyothi-y please let us know if there is anything we can help with. In case it helps, GraalPy EA builds are released under GFTC, the same license as Oracle GraalVM, which is integrated into setup-java. |
Thank you for this contribution, @timfel! 👋 We've started looking into this PR for reviewing. This looks like a valuable addition to support GraalPy Windows builds and early access versions. We'll review the changes to the scripts and test updates, and provide feedback soon. Appreciate your patience! |
Hi @timfel, To help us get this merged, could you please:
Please let me know if you need any assistance with resolving conflicts or CI issues – I'm happy to help! Thanks again for your work on this! |
9c4618d
to
c884be3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request adds Windows support and early access builds for GraalPy installations. The changes enable Windows builds which are now considered stable enough for users and make early access builds from a separate repository available.
Key changes include:
- Adding Windows support with zip extraction and proper binary path handling
- Including early access builds from the graal-languages-ea-builds repository
- Updating tests to run on Windows and use new version patterns
Reviewed Changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
File | Description |
---|---|
src/utils.ts | Updated comment to remove GraalPy reference since it now has Windows-specific handling |
src/install-graalpy.ts | Added Windows zip extraction, early access builds fetching, and updated version pattern matching |
src/find-graalpy.ts | Simplified binary path logic to use consistent 'bin' directory approach |
tests/install-graalpy.test.ts | Updated test cases for new version patterns and enabled Windows testing |
tests/find-graalpy.test.ts | Removed Windows test skipping and updated version references |
.github/workflows/test-graalpy.yml | Added Windows to the test matrix |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
c884be3
to
84a937d
Compare
84a937d
to
be60ae8
Compare
Description:
This adds two things:
Related issue:
#693 and the question after Windows support by @kurtmckee in #694 (comment)
Check list:
[ ] Mark if documentation changes are required.None required.