-
Notifications
You must be signed in to change notification settings - Fork 4
chore(deps): update dependency sphinx-toolbox to v4 #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Claude finished @renovate[bot]'s task —— View job ✅ sphinx-toolbox v4 upgrade - APPROVEDSummaryThis PR upgrades Validation Results
Breaking Changes Analysis (v3.10.0 → v4.0.0)Primary Breaking Change: The Impact on This SDK: ✅ NONE This SDK explicitly enables the extension in extensions = [
"sphinx_toolbox.collapse",
"sphinx_toolbox.sidebar_links",
"sphinx_toolbox.github", # ← Explicitly enabled
"sphinx_toolbox.source",
...
]Since the extension is already manually configured, the v4.0.0 behavioral change does not affect documentation builds. Other changes (4 commits total):
Files Changed
Recommendations✅ APPROVE AND MERGE This is a safe, straightforward dependency upgrade:
Verification CommandsFor maintainers who want to verify locally: # Build documentation with v4
make docs
# Run linting
make lint
# Run unit tests
make test_unitAll commands execute successfully with sphinx-toolbox v4.0.0. |
8c5fbbb to
a36483a
Compare
|
Claude finished @renovate[bot]'s task —— View job Re-reviewing sphinx-toolbox v4 upgrade after PR synchronizationThis PR was previously reviewed and approved on Nov 2. Re-validating after synchronization event. Todo List
✅ Re-validation Complete - APPROVEDThis PR remains SAFE TO MERGE after synchronization. SummaryThe PR was rebased on top of main (now includes commits #249 and #248) and all validations continue to pass successfully with sphinx-toolbox v4.0.0. Validation Results After Synchronization
What Changed in SynchronizationThe branch was rebased to include:
No conflicts with the sphinx-toolbox upgrade - the changes are independent. Files Modified
Breaking Changes Analysis (Re-confirmed)v3.10.0 → v4.0.0 breaking change: Impact: ✅ NONE - This SDK explicitly enables the extension in extensions = [
"sphinx_toolbox.collapse",
"sphinx_toolbox.sidebar_links",
"sphinx_toolbox.github", # ← Explicitly enabled
"sphinx_toolbox.source",
...
]Test Marker ObservationFound 1 test without category markers ( Recommendation: Address in a separate PR to add Documentation Build OutputBuilt successfully with 43 warnings - all are pre-existing duplicate object warnings for Example warnings: These warnings existed before this upgrade and are unrelated to the dependency change. Final Recommendation✅ APPROVE AND MERGE This dependency upgrade is:
|
|



This PR contains the following updates:
>=3.9.0,<4->>=4,<5Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
sphinx-toolbox/sphinx-toolbox (sphinx-toolbox)
v4.0.0: Version 4.0.0Compare Source
Automatically copied from PyPI.
Powered by OctoCheese
repo | 🙋 issues | 🏪 marketplace
📝 docs |
Configuration
📅 Schedule: Branch creation - "before 2am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.