Skip to content

handle multiple values for a GET parameter as p=1&p=2 instead of p=1,2 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

handle multiple values for a GET parameter as p=1&p=2 instead of p=1,2 #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
80a9d22
upgrade karma
mwhite Jan 11, 2016
abe949d
handle multiple values for GET parameters
mwhite Jan 11, 2016
52ee68d
modify to work on node
mwhite Jan 28, 2016
26762b0
temporarily add explicit xmlhttprequest dependency
mwhite Feb 4, 2016
4c9c5c1
remove xmlhttprequest dependency
mwhite Feb 4, 2016
8de897e
don't assume browser environment
mwhite Feb 5, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions backbone.nativeajax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,14 @@
// https://github.com/akre54/Backbone.NativeAjax

(function (factory) {
if (typeof define === 'function' && define.amd) { define(factory);
} else if (typeof exports === 'object') { module.exports = factory();
} else { Backbone.ajax = factory(); }
}(function() {
if (typeof define === 'function' && define.amd) {
define(factory.bind(this, this.XMLHttpRequest));
} else if (typeof exports === 'object') {
module.exports = factory(require('xmlhttprequest').XMLHttpRequest);
Copy link
Owner

@akre54 akre54 Mar 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be necessary now. If it's only for testing, let's do that in the tests file.

} else {
Backbone.ajax = factory(XMLHttpRequest);
}
}(function(XMLHttpRequest) {
// Make an AJAX request to the server.
// Usage:
// var req = Backbone.ajax({url: 'url', type: 'PATCH', data: 'data'});
Expand All @@ -33,7 +37,7 @@
var isValid = function(xhr) {
return (xhr.status >= 200 && xhr.status < 300) ||
(xhr.status === 304) ||
(xhr.status === 0 && window.location.protocol === 'file:')
(xhr.status === 0 && typeof window !== "undefined" && window.location.protocol === 'file:')
};

var end = function(xhr, options, promise, resolve, reject) {
Expand Down Expand Up @@ -98,7 +102,11 @@
'=' + encodeURIComponent(value);
};
for (var key in options.data) {
query += stringifyKeyValuePair(key, options.data[key]);
var value = options.data[key];
var values = Array.isArray(value) ? value : [value];
for (var i=0; i < values.length; i++) {
query += stringifyKeyValuePair(key, values[i]);
}
}

if (query) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"devDependencies": {
"backbone": "1.2.1",
"chai": "^3.0.0",
"karma": "^0.12.36",
"karma": "^0.13.9",
Copy link
Owner

@akre54 akre54 Jan 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do these updates separately please?

Copy link
Author

@mwhite mwhite Jan 11, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was motivated by karma failing to properly load the webpack module when running npm install && npm run-script test on a fresh checkout, which is a bug mentioned elsewhere that's fixed by upgrading karma.

Copy link
Author

@mwhite mwhite Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the sinon change and the tests still pass on travis. Sorry for all the noise on this small PR.

Copy link
Owner

@akre54 akre54 Jan 12, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good. Thanks for pointing it out :)

Copy link
Owner

@akre54 akre54 Mar 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed now.

"karma-chrome-launcher": "^0.1.12",
"karma-cli": "0.0.4",
"karma-firefox-launcher": "^0.1.6",
Expand Down
6 changes: 6 additions & 0 deletions test/ajax.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,12 @@ describe('Backbone.NativeAjax', function() {
expect(open).to.have.been.calledOnce;
expect(open).to.have.been.calledWithExactly('GET', 'test?a=1&b=2', true);
});
it('should handle multiple values for a GET parameter', function() {
ajax({url: 'test', dataType: 'json', data: {a: [1, 2]}});

expect(open).to.have.been.calledOnce;
expect(open).to.have.been.calledWithExactly('GET', 'test?a=1&a=2', true);
})
});

describe('headers', function() {
Expand Down